Skip to content

Fix use-after-free in setupOrigin and fetchOrigin #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boomatang merged 1 commit into from
Jun 4, 2026
Merged

Fix use-after-free in setupOrigin and fetchOrigin #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changes/unreleased/Fixed-20260604-205235.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
kind: Fixed
body: Working path was de-allocator before use. This cause the origins not to be configured correctly. This bug was introduced during the zig 0.16.0 upgrade.
time: 2026-06-04T20:52:35.308341822+01:00
4 changes: 2 additions & 2 deletions src/root.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ pub fn linkGit(io: std.Io, path: std.Io.Dir) !void {

pub fn setupOrigin(allocator: std.mem.Allocator, io: std.Io, path: std.Io.Dir) !void {
const _path = try path.realPathFileAlloc(io, ".", allocator);
allocator.free(_path);
defer allocator.free(_path);
const cmd = [_][]const u8{
"git",
"-C",
Expand All @@ -260,7 +260,7 @@ pub fn setupOrigin(allocator: std.mem.Allocator, io: std.Io, path: std.Io.Dir) !

pub fn fetchOrigin(allocator: std.mem.Allocator, io: std.Io, path: std.Io.Dir) !void {
const _path = try path.realPathFileAlloc(io, ".", allocator);
allocator.free(_path);
defer allocator.free(_path);
const cmd = [_][]const u8{ "git", "-C", _path, "fetch", "-p", "origin" };
const result = std.process.run(allocator, io, .{
.argv = &cmd,
Expand Down
Loading