Add HTTP/HTTPS clone URL parsing support - #86
Merged
Conversation
Signed-off-by: Jim Fitzpatrick <jimfity@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #85
The URL parser now supports
http://andhttps://clone URLs in addition to the existing SSH (git@andssh://git@) formats. The presence of an@symbol is used to distinguish SSH from HTTP URLs, then protocol-appropriate delimiters handle the rest of the parsing.The
.gitsuffix detection was also improved by usingfindLastinstead offind, correctly handling project names that contain.git(e.g.,.github).Acceptance Criteria
The issue requires HTTP clone support that works for both GitHub and Codeberg repos.
https://github.com/Boomatang/git-grab.git-- correctly parses site (github.com), owner (Boomatang), and name (git-grab).http://codeberg.org/boomatang/boomatang.git-- correctly parses site (codeberg.org), owner (boomatang), and name (boomatang).Test Plan
.git(.github.git)