Conversation
There was an extra } added to the json objects causing malformed json strings. Also some renaming of the allocator to gpa has being done. Signed-off-by: Jim Fitzpatrick <jimfity@gmail.com>
The documentation has being updated to have clearer guidance. Signed-off-by: Jim Fitzpatrick <jimfity@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace auto-generated clap help output with manually formatted help strings for the main,
get, anddiffcommands. Each subcommand now has a dedicated help page with usage patterns, descriptions, requirements, and flag documentation. The README has been updated to reflect the new subcommand-based help layout.Additionally, fix a bug where the JSON output for individual resources produced invalid JSON by appending an extra closing brace (
}}instead of}).Changes
help.zigmodule containing hand-crafted help text for the main CLI,get, anddiffsubcommands--helpinmain.zig,get.zig, anddiff.zigto use the new help module instead of clap's auto-generated outputResource.toJsonwhich was appending}}(two closing braces) instead of a single}, producing malformed JSONallocatorparameter togpain several functions for consistency with the rest of the codebase