Fix filter logic to support both old and new body formats in issue detection#49
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: BorDevTech <73800053+BorDevTech@users.noreply.github.com>
Co-authored-by: BorDevTech <73800053+BorDevTech@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] The filter logic assumes the old body format with
Fix filter logic to support both old and new body formats in issue detection
Sep 22, 2025
**Rule:** \${ruleId}\` but the new format uses ## 🔧 ${ruleId}`. This could miss existing issues that use the new format when searching with the old rule-based queries.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the GitHub issue detection logic to support both old and new body formats when searching for existing issues, preventing potential duplicate issue creation.
- Updated filter logic in
checkExistingRuleIssuemethod to check for both old (**Rule:** \${ruleId}`) and new (## 🔧 ${ruleId}`) body formats - Maintains backward compatibility while supporting the current implementation format
- Ensures proper detection of existing issues regardless of format used
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
checkExistingRuleIssuemethod was only checking for the old body format when filtering existing GitHub issues, potentially missing issues that use the new format.Problem
The filter logic in
github-issue-creator.tsassumed the old body format with**Rule:** \${ruleId}`but the new format uses## 🔧 ${ruleId}`. This could cause the system to miss existing issues that use the new format when searching with rule-based queries, potentially leading to duplicate issue creation.Solution
Updated the filter condition to check for both formats:
This ensures backward compatibility while supporting the current implementation format.
Testing
Fixes #48.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.