Fix MovieOutput crash when recording isn't started immediately#149
Open
jfuerth wants to merge 1 commit intoBradLarson:masterfrom
Open
Fix MovieOutput crash when recording isn't started immediately#149jfuerth wants to merge 1 commit intoBradLarson:masterfrom
jfuerth wants to merge 1 commit intoBradLarson:masterfrom
Conversation
Fixes "Cannot call method when status is 1" on call to startRecording() that happens if recording isn't started immediately after attaching the input. This fix makes it possible to attach the MovieOutput to the camera up front and then call startRecording later on without any visual hiccups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes "Cannot call method when status is 1" on call to startRecording()
that happens if recording isn't started immediately after attaching the
input. This fix makes it possible to attach the MovieOutput to the
camera up front and then call startRecording later on without any visual
hiccups.