On iOS Simulator, try Camera() fails to throw CameraError but crashes in deinit()#52
Open
simonkim wants to merge 3 commits intoBradLarson:masterfrom
Open
On iOS Simulator, try Camera() fails to throw CameraError but crashes in deinit()#52simonkim wants to merge 3 commits intoBradLarson:masterfrom
simonkim wants to merge 3 commits intoBradLarson:masterfrom
Conversation
The test case reproduces runtime crash 'fatal error: unexpectedly found nil while unwrapping an Optional value'
Setting nil to videoOutput before throwing an Exception in Camera.init() causes deinit() fails to access self.videoOutput. Instead, it's safer to initialize videoOutput with a proper value. With this change, testCameraError() in iOS GPUImageTests passes
|
💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
videoOutput!member of Camera class set to nil before throwingCameraErrorand that causesCamera.deinit()crash withwhile attempting to access
videoOutput!To solve the issue, these changes: