Skip to content

EPMLABSBRN-2299 [BE & FrontEnd] Refactoring: merge controllers StudyH…#2302

Open
Isink21 wants to merge 1 commit into
masterfrom
EPMLABSBRN-2299_Refactoring_StudyHistoryController
Open

EPMLABSBRN-2299 [BE & FrontEnd] Refactoring: merge controllers StudyH…#2302
Isink21 wants to merge 1 commit into
masterfrom
EPMLABSBRN-2299_Refactoring_StudyHistoryController

Conversation

@Isink21

@Isink21 Isink21 commented Sep 22, 2022

Copy link
Copy Markdown
Contributor

…istoryController and StudyHistoryControllerV2 into one class

EPMLABSBRN-XX

Description:

…istoryController and StudyHistoryControllerV2 into one class
@Isink21 Isink21 requested a review from ElenaSpb as a code owner September 22, 2022 10:32
@gitpod-io

gitpod-io Bot commented Sep 22, 2022

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Frontend test coverage: 95.45%

🤷‍♂️ Did not change

@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@github-actions

Copy link
Copy Markdown

Gradle Unit and Integration Test Results

446 tests  ±0   442 ✔️ ±0   58s ⏱️ -1s
107 suites  - 1       4 💤 ±0 
107 files    - 1       0 ±0 

Results for commit d78ba87. ± Comparison against base commit 20c4053.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
com.epam.brn.integration.StudyHistoryControllerV2IT ‑ getHistories should return histories for period of time for user with role user()
com.epam.brn.integration.StudyHistoryControllerV2IT ‑ getHistories should return histories for period of time()
com.epam.brn.integration.StudyHistoryControllerV2IT ‑ isUserHasStatistics should return true when user has statistics for user with role user()
com.epam.brn.integration.StudyHistoryControllerV2IT ‑ isUserHasStatistics should return true when user has statistics()
com.epam.brn.integration.StudyHistoryControllerIT ‑ getHistories should return histories for period of time for user with role user()
com.epam.brn.integration.StudyHistoryControllerIT ‑ getHistories should return histories for period of time()
com.epam.brn.integration.StudyHistoryControllerIT ‑ isUserHasStatistics should return true when user has statistics for user with role user()
com.epam.brn.integration.StudyHistoryControllerIT ‑ isUserHasStatistics should return true when user has statistics()

@ElenaSpb ElenaSpb self-assigned this Sep 23, 2022
@ElenaSpb

Copy link
Copy Markdown
Contributor

This task is not only about backend - it is general task about front and back.
now this changes will broke the platform

so you need to find all usages of this end-points and change them too

@ElenaSpb ElenaSpb requested a review from marklekin September 23, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants