Skip to content

#2406 Add lastVisit field and set it when user logs in#2527

Merged
ElenaSpb merged 13 commits into
Brain-up:masterfrom
naXa777:issue/2406
Oct 27, 2023
Merged

#2406 Add lastVisit field and set it when user logs in#2527
ElenaSpb merged 13 commits into
Brain-up:masterfrom
naXa777:issue/2406

Conversation

@naXa777

@naXa777 naXa777 commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

Closes #2406 "Add lastVisit field and set it when user logs in"

Changes description:

  • I pulled PR with unfinished work 2406: add last visit field and set it when user logs in #2444
  • I exposed new lastVisit field in UserWithAnalyticsResponse returned by GET /users?withAnalytics=true API
  • The registration date is used as "Last Visit" date in API response, if last visit date is unknown.
  • Code refactoring.
  • Integration with admin UI.

Comment thread src/main/kotlin/com/epam/brn/service/impl/UserAccountServiceImpl.kt Outdated
@ElenaSpb ElenaSpb self-assigned this Oct 20, 2023
@ElenaSpb

Copy link
Copy Markdown
Contributor

could you please join our dev chat
https://t.me/+R-6ThlxgP5QyZmMy

Comment thread src/main/kotlin/com/epam/brn/auth/filter/FirebaseTokenAuthenticationFilter.kt Outdated
Comment thread src/main/resources/db/migration/V220230119_2406.sql
@ElenaSpb

ElenaSpb commented Oct 24, 2023

Copy link
Copy Markdown
Contributor

also

  1. from task we have
    "current value from Last Visit move to field lastStudyActivity"
    do you want to implement it too?

  2. I think it would be logically to set lastVisit in case null - the registration date. it can not be null

@naXa777

naXa777 commented Oct 24, 2023

Copy link
Copy Markdown
Collaborator Author

I think it would be logically to set lastVisit in case null - the registration date. it can not be null

Done.

@naXa777

naXa777 commented Oct 24, 2023

Copy link
Copy Markdown
Collaborator Author

"current value from Last Visit move to field lastStudyActivity"
do you want to implement it too?

yes, but I don't see "Last Visit" field anywhere in code. There was no Last Visit field before, or maybe it was removed recently, IDK. @ElenaSpb, please clarify this requirement.

UPD: yes, I see lastDone field. Let me implement the change.

@naXa777

naXa777 commented Oct 24, 2023

Copy link
Copy Markdown
Collaborator Author

some checks have failed. and I suspect that they are broken, cause it's not related to the changes in PR #2527.

I kindly ask to merge this PR and fix the failing GitHub actions separately:

@naXa777 naXa777 requested a review from ElenaSpb October 24, 2023 19:17
@ElenaSpb ElenaSpb requested review from Mikleprog and lifeart October 27, 2023 10:58
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@ElenaSpb ElenaSpb merged commit 3112171 into Brain-up:master Oct 27, 2023
@ElenaSpb

Copy link
Copy Markdown
Contributor

Thank you for contribution to our project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BE] Add new field LastVisit field in https://brainup.fun/admin/users response

4 participants