Replace deprecated pkg_resources with importlib.metadata#8
Open
NGeorgescu wants to merge 1 commit into
Open
Conversation
pkg_resources was removed from setuptools' default install in recent versions and is unavailable on Python 3.12+ in many environments, causing 'ModuleNotFoundError: No module named pkg_resources' on import. importlib.metadata is part of the standard library since Python 3.8 and is the recommended replacement.
BreadMakesYouFull
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
baseconvert/__init__.pyimportspkg_resourcesto read the package version.pkg_resourcesis part of the legacysetuptoolsdistribution and is no longer installed by default in many modern Python environments (notably Python 3.12+ on several distros and virtualenvs), so simply doingimport baseconvertfails with:This PR switches to
importlib.metadata.version, which has been part of the standard library since Python 3.8 and is the officially recommended replacement (pkg_resourcesis deprecated upstream).Test plan
python -c "import baseconvert; print(baseconvert.__version__)"works on Python 3.14 withoutsetuptoolsinstalled