Skip to content

Conversation

@rouille
Copy link
Collaborator

@rouille rouille commented May 2, 2023

Pull Request doc

Purpose

Format code, set python version in Pipfile, update Pipefile.lock and use requirements.txt for running tests. Closes #386.

What the code is doing

N/A

Testing

Existing unit tests

Where to look

  • A new version of black requires some formatting in the test_emissions and plot_tornado modules
  • There is a security issue related to cryptography 38.0.4. A new Pipefile.lock has been generated with bumped dependencies.
  • For the same reason discussed here, the dependencies are installed using the requirements.txt file to run the tests.
  • The python version is added to Pipfile

Usage Example/Visuals

N/A

Time estimate

5min

@rouille rouille added the dependencies Pull requests that update a dependency file label May 2, 2023
@rouille rouille requested review from BainanXia and jenhagg May 2, 2023 22:37
@rouille rouille self-assigned this May 2, 2023
@rouille
Copy link
Collaborator Author

rouille commented May 16, 2023

@jenhagg, do you have time to look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants