Skip to content

Remove all SaaS billing code from HoldFast #25

Description

@BrewingCoder

Summary

HoldFast is self-hosted only with no SaaS model. The upstream Highlight.io billing code was partially stubbed but never fully removed. This tracking issue covers the complete removal of all billing-related code.

Principle: Remove one element at a time, trace usage up the stack to the frontend, branch per issue, and verify with passing tests before merging.

Billing Elements to Remove

Backend Model Layer (do in order)

Email / SendGrid

Frontend (do last)

Suggested Order

  1. Remove SendBillingNotifications, BillingEmailHistory, and emailHistoryCache #26 (SendBillingNotifications) — standalone, low risk
  2. Remove AWSMarketplaceCustomer model #27 (AWSMarketplaceCustomer) — standalone, low risk
  3. Remove PromoCode field and hardcoded PromoCodes map #34 (PromoCode) — standalone, low risk
  4. Remove AllowMeterOverage and CanShowBillingIssueBanner #33 (AllowMeterOverage + banner) — standalone, low risk
  5. Remove pricing package and quota checking system #28 (pricing/quota) — biggest change, unblocks Remove Workspace Stripe fields #29, Remove Workspace billing period fields #30, Remove Workspace monthly limit and max cents fields #31
  6. Remove Workspace Stripe fields #29 (Stripe fields) — after Remove pricing package and quota checking system #28
  7. Remove Workspace billing period fields #30 (billing periods) — after Remove pricing package and quota checking system #28
  8. Remove Workspace monthly limit and max cents fields #31 (limits/cents) — after Remove pricing package and quota checking system #28
  9. Remove Workspace trial fields and trial extension logic #32 (trial fields) — touches frontend
  10. Remove billing email types and SendGrid integration #35 (email/SendGrid) — after Remove SendBillingNotifications, BillingEmailHistory, and emailHistoryCache #26
  11. Remove frontend billing pages and trial UI components #36 (frontend) — after all backend done

Related Issues

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions