Make the build script work on Debian sid#1111
Merged
matty0ung merged 3 commits intoBrewtarget:mainfrom May 4, 2026
Merged
Conversation
…, which makes parse() crash. Since major and minor versions are mostly used for logging, let's use dummy values if this happens
matty0ung
requested changes
May 3, 2026
Member
matty0ung
left a comment
matty0ung
left a comment
There was a problem hiding this comment.
Thanks for this! Always good to get things running on more distros.
(I had run lsb_release -a on my Debian Trixie box, where it works fine, but didn't know it's problematic on Sid.)
I think you want to lose the 'break' line as it, err, breaks things. 😸 Otherwise looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
When building brewtarget on my Debian sid laptop, I had to change a few things to make
btwork:getLinuxDistroInfobecauselsb_release -areturns 'n/a' on Debian sid, which makes parsing the version number crash.