Simple service: Portable Version Data. - #37
Open
lonegraywolf2000 wants to merge 1 commit into
Open
Conversation
This allows the version to be set in one place to be reused throughout the code base and `AutoUpdateInfo.xml` file with no need to worry about manually modifying the version in multiple files. The parameters in the PowerShell/bash script are just defaulted to the current version. Also, good way to introduce dependency injection & unit tests.
Owner
|
I am admittedly a little cautious about touching the auto updater code since it is so critical for users, do we have some way to verify this updates properly? |
Contributor
Author
|
Full on integration test wise? That, I'm unsure of. Also...kind of forgot that the NuGet package we're using here only works for Windows. So it would have to be replaced with a new library. The goal was to demonstrate how I would use Dependency Injection...and I guess that was done. I'll see about activating the other PR I had in mind instead. I'll look into either NetSparkleUpdater or Velopack depending on which one you feel is best. Your call if we should close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the version to be set in one place to be reused throughout the code base and
AutoUpdateInfo.xmlfile with no need to worry about manually modifying the version in multiple files. The parameters in the PowerShell/bash script are just defaulted to the current version.Also, good way to introduce dependency injection & unit tests.