Import export xlsx icalc separate wasm#11
Open
BrianHung wants to merge 439 commits into
Open
Conversation
BrianHung
force-pushed
the
import-export-xlsx-icalc-separate-wasm
branch
from
3fe119d to
b9f70b0
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bugbot free trial expires on August 2, 2025
Learn more in the Cursor dashboard.
| return Err(format!( | ||
| "The selected cell is not in one of the corners. Column '{selected_column}' and column range '({start_column}, {end_column})'" | ||
| )); | ||
| } |
There was a problem hiding this comment.
Bug: Row and Column Selection Comments Swapped
The comments describing full row and full column selections are swapped. The code block for start_row == 1 && end_row == LAST_ROW correctly handles full column selections but is incorrectly commented as 'full row selected'. Similarly, the block for start_column == 1 && end_column == LAST_COLUMN correctly handles full row selections but is incorrectly commented as 'full column selected'. While the validation logic within these blocks is correct for the actual selection type, the comments are misleading.
Locations (1)
…arning update: add data-storage warnings to the app
Uses statrs for numerical functions REFACTOR: Put statistical functions on its own module This might seem counter-intuitive but the wasm build after this refactor is 1528 bytes smaller :)
…ents fix: mobile issues in app
These are all functions that follow a very simmilar path code
Edited Column Documentation
* GAUSS * HARMEAN * KURT * MAXA * MEDIAN * MINA * RANK.EQ * RANK.AVG * SKEW * SKEW.P * SMALL * LARGE
this allows emotion theme to pick up outside context
FIX: Update docker tag
adding Documentation for CHOOSE function
After ironcalc#683 this broke the translation :S
Resolved conflicts: - .github/workflows/rust-build-test.yaml: accepted deletion (replaced by build-test.yaml in main) - Cargo.lock: accepted main's version - Makefile: kept xlsx_wasm build steps, added test-python target from main - bindings/wasm/Cargo.toml: kept ironcalc (xlsx) dependency, updated versions to 0.7 - bindings/wasm/src/lib.rs: kept js_name attribute, added language_id parameter
- load_from_icalc_bytes now requires language_id - fromXLSXBytes and toXLSXBytes now require language_id - Update tests to pass language_id argument - Update Model constructors to use 4 arguments
- Add lifetime parameter to load_from_icalc_bytes function - Fix code formatting in xlsx.rs
- Add wasm32-unknown-unknown target to lint-all and test-js jobs - Install wasm-bindgen-cli for test-js job (needed for xlsx_wasm build)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.