Skip to content

SUMPRODUCT#24

Open
BrianHung wants to merge 21 commits into
mainfrom
codex/implement-sumif,-sumifs,-and-sumproduct-functions-with-tests
Open

SUMPRODUCT#24
BrianHung wants to merge 21 commits into
mainfrom
codex/implement-sumif,-sumifs,-and-sumproduct-functions-with-tests

Conversation

@BrianHung

@BrianHung BrianHung commented Jul 13, 2025

Copy link
Copy Markdown
Owner

Summary

  • implement SUMPRODUCT function
  • enable SUMIF and SUMIFS in docs
  • add tests for SUMIF and SUMPRODUCT

Testing

  • cargo test --workspace --lib

https://chatgpt.com/codex/tasks/task_e_68657274956c83279330f179fe5fc4aa

@BrianHung BrianHung mentioned this pull request Jul 14, 2025
Closed
@BrianHung BrianHung changed the title Implement SUMIF/SUMIFS/SUMPRODUCT sumif, sumifs, sumproduct Jul 14, 2025
@BrianHung

BrianHung commented Jul 19, 2025

Copy link
Copy Markdown
Owner Author

cursor review
make sure there are comprehensive tests for each function, functions are ticked as available, and properly documented with their own page stub

cursor[bot]

This comment was marked as outdated.

Sign in to view

@BrianHung

BrianHung commented Jul 20, 2025

Copy link
Copy Markdown
Owner Author

Should be its own PR.

@BrianHung

BrianHung commented Jul 21, 2025

Copy link
Copy Markdown
Owner Author

cursor review
make sure there are comprehensive tests for each function, functions are ticked as available, and properly documented with their own page stub

cursor[bot]

This comment was marked as outdated.

Sign in to view

@BrianHung

BrianHung commented Jul 22, 2025

Copy link
Copy Markdown
Owner Author

cursor review
make sure there are comprehensive tests for each function, functions are ticked as available, and properly documented with their own page stub

cursor[bot]

This comment was marked as outdated.

Sign in to view

@BrianHung BrianHung added the ready to merge PRs ready to merge label Jul 22, 2025
@BrianHung

BrianHung commented Jul 22, 2025

Copy link
Copy Markdown
Owner Author

cursor review
make sure there are comprehensive tests for each function, functions are ticked as available, and properly documented with their own page stub (page stubs do not have to be created in this commit or PR they just have to exist :))

cursor[bot]
cursor Bot reviewed Jul 22, 2025
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Function Documentation Pages

The documentation marks SUMIF and SUMIFS as 'Available' with links to their documentation pages (SUMIF and SUMIFS). However, these linked page stubs are not visible in the provided diff, indicating they may not exist. This violates the requirement that functions must be 'properly documented with their own page stub' that 'just have to exist' to prevent 404 errors, unlike SUMPRODUCT which had its page updated.

docs/src/functions/math-and-trigonometry.md#L85-L88

IronCalc/docs/src/functions/math-and-trigonometry.md

Lines 85 to 88 in b3c2224

| SUM | <Badge type="tip" text="Available" /> | – |
| SUMIF | <Badge type="tip" text="Available" /> | [SUMIF](math_and_trigonometry/sumif) |
| SUMIFS | <Badge type="tip" text="Available" /> | [SUMIFS](math_and_trigonometry/sumifs) |
| SUMPRODUCT | <Badge type="tip" text="Available" /> | [SUMPRODUCT](math_and_trigonometry/sumproduct) |

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

@BrianHung BrianHung changed the title sumif, sumifs, sumproduct SUMPRODUCT Feb 1, 2026
dg-ac and others added 16 commits February 4, 2026 19:22
@dg-ac @nhatcher
update: add 3 more border styles
4953ddd
@dg-ac @nhatcher
update: use a popper instead of a popover
27367b1
@dg-ac @nhatcher
update: add a timeout in nested menu
009b06e
@dg-ac @nhatcher
chore: remove duplications in worksheetcanvas
6b1e9b7
@dg-ac @nhatcher
update: add 3 more styles
ebb0446
@dg-ac @nhatcher
fix: comments
88410df
@rezat-c @nhatcher
fix: treat leading comma as text
163fa3b
@elsaminsut @nhatcher
fix: add support for booleans and upper bound for df (ironcalc#734 and …
8acef66 
…ironcalc#735)
@elsaminsut @nhatcher
update: add unit test for bug fix
af0a180
@elsaminsut @nhatcher
fix: add max deg of freedom as constant
e22549c
@elsaminsut @nhatcher
update: adds locale testing for database functions
38c4787 
# Conflicts:
#	base/src/test/test_database.rs
@elsaminsut @nhatcher
fix: changes to locale name, use correct formula delimitter for de
d6ea5e6
@nhatcher
FIX: Cut and paste on partially selected range
d4015cd
@nhatcher
FIX: Adds missing test
21631e0
@BrianHung
Implement SUMIF, SUMIFS, SUMPRODUCT functions
17be835
@BrianHung
fix out of bounds
42a78e3
@BrianHung
increase test coverage
0170947
@BrianHung
Add SUMPRODUCT function (SUMIF/SUMIFS already in upstream)
8cdfdf4 
SUMPRODUCT multiplies corresponding elements in arrays and returns
the sum of those products. This is useful for weighted calculations.

Implementation:
- Handles both range and array arguments
- Validates dimension compatibility
- Proper error propagation for non-numeric values
- Uses hardcoded function lookup (no language.bin changes)

Tests: 6 comprehensive tests covering basic usage, arrays, scalars,
data types, edge cases, and error conditions.

Note: SUMIF and SUMIFS from original PR are now in upstream.
@BrianHung
Clean up SUMPRODUCT: remove redundant comments
9febe01 
- Remove verbose comments that repeat what code already expresses
- Use unreachable!() for logically impossible code path
- Keep defensive bounds check without explanatory comment
@BrianHung
Force GitHub to recalculate diff
aed768e
@BrianHung
Fix SUMPRODUCT registration and static analysis.
19752b1 
Add SUMPRODUCT to function tables and mark it available in docs.
@BrianHung BrianHung force-pushed the codex/implement-sumif,-sumifs,-and-sumproduct-functions-with-tests branch from 60c1ce4 to 19752b1 Compare February 9, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

Assignees

No one assigned

Labels

codex ready to merge PRs ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BrianHung @dg-ac @rezat-c @elsaminsut @nhatcher