ADDRESS, XMATCH, PROPER, REPLACE#53
Open
BrianHung wants to merge 25 commits into
Open
Conversation
This was referenced Jul 30, 2025
Closed
Closed
Closed
Closed
Closed
BrianHung
added a commit
that referenced
this pull request
Jan 30, 2026
- Added fn_xmatch implementation in xlookup.rs with full support for: - All match modes (exact, smaller, larger, wildcard, regex) - All search modes (first-to-last, last-to-first, binary asc/desc) - Added Address, Xmatch, Proper, Replace to Function enum - Updated lookup macro to handle new functions without localization - Fixed text.rs import and TEXTJOIN bounds checking - Enabled XMATCH tests (7 passing tests) - All existing tests for ADDRESS, PROPER, REPLACE pass
# Conflicts: # base/src/test/test_database.rs
- Added fn_xmatch implementation in xlookup.rs with full support for: - All match modes (exact, smaller, larger, wildcard, regex) - All search modes (first-to-last, last-to-first, binary asc/desc) - Added Address, Xmatch, Proper, Replace to Function enum - Updated lookup macro to handle new functions without localization - Fixed text.rs import and TEXTJOIN bounds checking - Enabled XMATCH tests (7 passing tests) - All existing tests for ADDRESS, PROPER, REPLACE pass
BrianHung
force-pushed
the
brian/text-and-lookup-functions
branch
from
67c61f9 to
16a445f
Compare
Remove unsupported regex matching, align static analysis, and coerce REPLACE inputs consistently.
… into_iter 349, fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.