ACCRINT, ACCRINTM, COUPDAYBS, COUPDAYS, COUPDAYSNC, COUPNCD, COUPNUM, COUPPCD, DISC, DURATION, FVSCHEDULE, INTRATE, MDURATION, PRICE, PRICEDISC, PRICEMAT, RECEIVED, YIELD, YIELDDISC, YIELDMAT#54
Closed
BrianHung wants to merge 14 commits into
Conversation
Closed
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This was referenced Jul 31, 2025
Closed
Closed
Owner
Author
|
cursor review |
Merged upstream/main (429 commits) while preserving 20 new financial functions not yet in upstream: Bond Duration/Price/Yield: - DURATION, MDURATION - PRICE, PRICEDISC, PRICEMAT - YIELD, YIELDDISC, YIELDMAT Accrued Interest: - ACCRINT, ACCRINTM Coupon Functions: - COUPDAYBS, COUPDAYS, COUPDAYSNC - COUPNCD, COUPNUM, COUPPCD Other: - DISC, INTRATE, RECEIVED, FVSCHEDULE Implementation uses hardcoded function lookup (no language.bin changes). All existing financial function tests pass (23 tests).
Added test modules that were present but not declared: - test_fn_accrint (4 tests) - ACCRINT function - test_fn_accrintm (4 tests) - ACCRINTM function - test_fn_coupon (7 tests) - COUPDAYBS, COUPDAYS, COUPDAYSNC, etc. - test_fn_duration (9 tests) - DURATION, MDURATION - test_fn_financial_bonds (26 tests) - PRICE, YIELD, DISC, etc. - test_fn_fvschedule (7 tests) - FVSCHEDULE Total: 57 tests covering all 20 new financial functions. All CI checks pass (format, clippy, 1049 tests).
BrianHung
changed the title
- Inline argument parsing to match codebase patterns (mathematical.rs) - Fix ACCRINT: allow settlement before first_interest date - Add Excel documentation example tests for ACCRINT/ACCRINTM
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.