PERMUT, PERMUTATIONA#60
Open
BrianHung wants to merge 22 commits into
Open
Conversation
BrianHung
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Owner
Author
|
cursor review |
BrianHung
changed the title
BrianHung
changed the title
# Conflicts: # base/src/test/test_database.rs
BrianHung
force-pushed
the
codex/implement-excel-functions-fact,-combin,-combina,-permut,-per
branch
from
455bbfd to
e5bddaa
Compare
- Add MAX_N (1e15) and MAX_K (1e6) early return for #NUM! on huge args - Check result.is_infinite() in loop and return #NUM! - Update combina_comprehensive to expect #NUM! for COMBINA(0,3) to match existing COMBIN_COMBINA.xlsx round-trip test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
cargo test --lib --quiethttps://chatgpt.com/codex/tasks/task_e_6889d70336bc83278e749c532100d4eb