fix(ci): pass repository to release lifecycle commands - #10
Merged
Conversation
Signed-off-by: Brian Charbonneau <github@briancharbonneau.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Owner
Author
|
CI disposition: the PR-scoped private-CA release contract and dead-token guard passed. The macOS lane reproduced the already documented base workflow failure before product compilation ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
view,comment, andcloserepository context in the release contract testReproduction
Adding
builtto monitor-created issue #3 launched run 30727885122. The job failed before validating the marker becausegh issue viewreportedfatal: not a git repository; the job has no checkout from whichghcan infer a repository.Solution
Use
--repo "$GITHUB_REPOSITORY"for issue reads, comments, and closes in the skip, built, accepted, approval, and local handoff jobs. This keeps these jobs checkout-free and least-privilege while making repository selection deterministic.Validation
scripts/test-private-ca-release-contract.shshellcheck scripts/test-private-ca-release-contract.sh scripts/normalize-private-ca-desktop-tag.shgit diff --checkAfter merge, removing/re-adding the existing
builtlabel on issue #3 will retry only the already-accepted v0.5.2 lifecycle record; it will not build or install v0.5.3.