Skip to content

Color JSON properties blue#14

Open
MoritzKn wants to merge 1 commit into
Briles:masterfrom
MoritzKn:color-json-properties
Open

Color JSON properties blue#14
MoritzKn wants to merge 1 commit into
Briles:masterfrom
MoritzKn:color-json-properties

Conversation

@MoritzKn
Copy link
Copy Markdown

Before After
image image

@Briles
Copy link
Copy Markdown
Owner

Briles commented Jan 20, 2018

I like this change! It'd be best if we can maintain the punctuation color, though.

@MoritzKn
Copy link
Copy Markdown
Author

Does this mean I should change the color to @foreground or what would be the concrete change? Sorry, I do not have much experience with syntax themes.

@MoritzKn
Copy link
Copy Markdown
Author

@Briles Could you take a look at this again?

@idoo
Copy link
Copy Markdown

idoo commented Aug 8, 2018

@Briles I hope you're good, do you have a chance to take a look to this MR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants