.add getGeneratedKeys to provide ability to get batch insert's keys.#12
.add getGeneratedKeys to provide ability to get batch insert's keys.#12johnhx wants to merge 1 commit into
Conversation
|
@johnhx thank you for the addition, I like it. The one thing I am going to change is to not store the batchResult in the runner and provide the generatedKeys as a return of execBatch as we do for returning id on insert. I will let you know when I add this feature. Will try to do it today. Hope this makes sense. Feel free to let me know if I missed something. |
|
Jeremy Chone,
Thank you for your quick response on this pull request.
Feel free to do any changes you want to make it better.
J8ql is really lightweight and I tried to use it in a project and found it was lacked of getGeneratedKeys for batch insert, which is the trigger for this pull request.
… On 6 May 2017, at 11:33 PM, Jeremy Chone ***@***.***> wrote:
@johnhx thank you for the addition, I like it. The one thing I am going to change is to not store the batchResult in the runner and provide the generatedKeys as a return of execBatch as we do for returning id on insert.
I will let you know when I add this feature. Will try to do it today.
Hope this makes sense. Feel free to let me know if I missed something.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@johnhx Cool, the requirement make sense, I will make couple of changes to fit into the api patterns. Did not have time to do it yesterday, so, will try to come around this week. Btw, do you know that in the insert or update queries, you can do a .returningId... which will return the keys. But this might not cover the batch, I need to check. Also, getting the standard getGeneratedKeys might be helpful. |
|
@jeremychone yes, I got to know .returningId which works for insert or update. |
Changelist: