Open
Conversation
Add a basic regex test for unix timestamp (casting string matched to number) instead of assuming incoming value's data type is number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTEXT:
Column rendering of dates in migxdb
PROBLEM:
When a unix timestamp is passed into the renderDate function, it's data type may be string instead of number (even though the database's column type is int). In this case, renderDate currently fails to recognize the data as a numeric timestamp and returns an empty string.
SOLUTION:
Adds a basic regex test for unix timestamp and explicitly casts a match to number (via parseInt) to ensure numeric string timestamps are rendered properly.