This repository was archived by the owner on Jan 22, 2023. It is now read-only.
Use obsverables duplex - #2
Open
adz5a wants to merge 2 commits into
Open
Conversation
Observables are great! Using thenm to model async producers and manipulate them as value is pretty cool! In this I make use of xstream and a simple middleware lib to use then to model Websocket subscription. Removing (almost) the use for thunks (which closes over the ws connexion).
The app uses redux as a state management utility, which means the
communication inside the app will be done using actions `{ type: String,
...body }`. Because actions are pure data passing them around using
observables is a way to model the data flow inside the code.
This PR refactors what was shown in the precedent PR (see first commit)
to enable a kind of "duplex" communication. The `createSocket$` utility
now takes an `action$` stream as input. Upon subscription it will create
a WS instance and connect (could be parameterized and made lazy easily).
It will then look for several actions with "special" types (qualified,
could be parameterized also). For instance if an action with type `
"SOCKET_SEND_MESSAGE"` is dispatched upstream, then if will convert
into JSON the action and send it via the websocket. When a message is
received a `"SOCKET_RECEIVED_MESSAGE"` is dispatched to consumers.
This means that the behaviour of the WS can be controlled entirely
through actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take actions as input to control the websocket behaviour