Skip to content

feat: implement login/signup modal#190

Merged
Rl0007 merged 6 commits into
mainfrom
feat/login-signup-modal
Mar 30, 2026
Merged

feat: implement login/signup modal#190
Rl0007 merged 6 commits into
mainfrom
feat/login-signup-modal

Conversation

@Rl0007
Copy link
Copy Markdown
Collaborator

@Rl0007 Rl0007 commented Mar 24, 2026

Demo

oauth.flow.mp4
  1. Dynamic Social Login Buttons (Populated based on Frappe's Social Login)
  2. Bigger Login Modal
  3. Social Login Buttons in Sign Up as well
  4. Banner stays always
  5. Removed banner animation as well.

Modal:

Screenshot 2026-03-30 at 1 00 28 AM

@Rl0007 Rl0007 added the Plan Review Review plan before implementing the feature label Mar 24, 2026
@Rl0007 Rl0007 requested a review from NagariaHussain March 24, 2026 11:33
@Rl0007 Rl0007 changed the title feat: include login/signup modal plan feat: implement login/signup modal Mar 24, 2026
@NagariaHussain
Copy link
Copy Markdown
Contributor

For the registration page, what we want is to refactor the flow. Right now, what happens is that if someone comes to the registration page and login is required, they are thrown to the login required component they have shown, and then the modal appears.

We want to do this instead, where they can view the registration form. This is just for the registration form, by the way, not the custom forms that we have done. Custom forms can still operate as they are doing.

In the registration page, they can see the form and do whatever they want. While checking out, if guest mode is not enabled, then the dialog appears that says "Log in to continue", and then it continues from there.

Copy link
Copy Markdown
Contributor

@NagariaHussain NagariaHussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comment.

@Rl0007
Copy link
Copy Markdown
Collaborator Author

Rl0007 commented Mar 25, 2026

@NagariaHussain Yes, that's the plan. Basically we are replacing the redirection to /login with the "Login/Signup" modal that is global in context so if down the line we decide to use the same modal for custom forms we can do that as well. Thoughts?

@NagariaHussain
Copy link
Copy Markdown
Contributor

NagariaHussain commented Mar 26, 2026

The plan md does not have this flow refactor mentioned, hence pointed out. Yes, it should be a layout level component.

@Rl0007 Rl0007 removed the Plan Review Review plan before implementing the feature label Mar 29, 2026
@Rl0007 Rl0007 requested a review from NagariaHussain March 29, 2026 19:31
@Rl0007
Copy link
Copy Markdown
Collaborator Author

Rl0007 commented Mar 29, 2026

@NagariaHussain there is still one issue of forgot password it looks like this

Screenshot 2026-03-30 at 12 46 19 AM

Shall I create custom page for it in this PR or in a separate PR?

@NagariaHussain
Copy link
Copy Markdown
Contributor

Let's do in a separate PR. Let's get this merged soon.

@Rl0007 Rl0007 merged commit 8a70ee5 into main Mar 30, 2026
6 checks passed
This was referenced Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants