chore(version-15): bring latest develop changes to version-15

.claude/skills/release/SKILL.md

@@ -0,0 +1,60 @@
+---
+name: release
+description: Draft a new GitHub release for buildwithhussain/forms_pro by inspecting existing releases and merged PRs since the last release. Use when the user wants to cut, draft, or create a release.
+argument-hint: [version]
+---
+
+You are preparing a new GitHub release for the repo `buildwithhussain/forms_pro`.
+
+## Steps
+
+1. **Fetch current releases**
+   Run: `gh release list --repo buildwithhussain/forms_pro`
+
+2. **Inspect the latest release** to get its tag and published date:
+   Run: `gh release view <latest-tag> --repo buildwithhussain/forms_pro`
+
+3. **List all merged PRs** since the last release (sorted by merge date):
+   Run: `gh pr list --repo buildwithhussain/forms_pro --state merged --limit 100 --json number,title,author,mergedAt | jq 'sort_by(.mergedAt)'`
+   Filter to only PRs merged **after** the last release's published date.
+
+4. **Determine the next version**
+   - If `$ARGUMENTS` is provided, use it as the tag (e.g. `v0.1.3-beta`).
+   - Otherwise, infer the next patch version from the latest tag (e.g. `v0.1.1-beta` → `v0.1.2-beta`).
+
+5. **Categorize PRs** into:
+   - **Features** — titles starting with `feat:`
+   - **Fixes** — titles starting with `fix:`
+   - **Chores / CI** — titles starting with `chore:`, `refactor:`, `ci:`, `docs:` — **omit these from release notes**
+
+6. **Show the user a plan**: list the proposed tag, target branch (`main`), and the drafted release notes. Ask for confirmation before creating anything.
+
+7. **After confirmation**, create a draft release:
+   ```
+   gh release create <tag> \
+     --repo buildwithhussain/forms_pro \
+     --title "<tag>" \
+     --draft \
+     --target main \
+     --notes "<release notes>"
+   ```
+
+8. Return the draft release URL so the user can review and publish it.
+
+## Release Notes Format
+
+Follow the same format as previous releases exactly:
+
+```markdown
+## What's Changed
+
+### Features
+* feat: <title> by @<author> in https://github.com/BuildWithHussain/forms_pro/pull/<number>
+
+### Fixes
+* fix: <title> by @<author> in https://github.com/BuildWithHussain/forms_pro/pull/<number>
+
+**Full Changelog**: https://github.com/BuildWithHussain/forms_pro/compare/<previous-tag>...<new-tag>
+```
+
+Omit a section entirely if there are no PRs in that category.

.claude/skills/writing-tests/SKILL.md

@@ -0,0 +1,149 @@
+---
+name: writing-tests
+description: Use when writing or modifying backend tests in `forms_pro/tests/`. Forms Pro test suites must build test documents via `frappe_factory_bot` factories rather than `frappe.new_doc` / `frappe.get_doc`. This skill explains where factories live, how to author one, and how to consume them in tests.
+---
+
+# Writing Tests (frappe_factory_bot)
+
+The dev bench has `frappe_factory_bot` installed alongside Forms Pro (`apps/frappe_factory_bot`, repo: `harshtandiya/frappe_factory_bot`). All Forms Pro tests build their fixtures through factories defined in `forms_pro/tests/factories/`.
+
+## Rules
+
+1. **Never** call `frappe.new_doc(...)` or `frappe.get_doc({...}).insert()` directly in a test to spin up a fixture. Use a factory.
+2. One factory per doctype. File name: `<snake_case_doctype>_factory.py` inside `forms_pro/tests/factories/`. **Naming exception**: when a doctype is used in a narrow domain context (e.g. the generic `"DocType"` doctype acting as a placeholder for a Form's linked DocType), name the factory after the domain — `LinkedFormDoctypeFactory`, not `DoctypeFactory`.
+3. Factory class name: `<PascalCaseDocType>Factory`, subclassing `BaseFactory[<DocClass>]` (parameterise the generic with the actual `Document` subclass for type hints).
+4. `default_attributes` must only set the minimum fields required for `.insert()` to succeed. Use `Faker` (`_fake = Faker()`) with `_fake.unique.*` when a field must be unique.
+5. Reuse the factory bot's primitives instead of reinventing them:
+   - **Traits**: extra `@property` methods returning attribute dicts. Apply with `Factory.create("trait_name")`.
+   - **Overrides**: kwargs to `create()` / `build()`. Take precedence over traits and defaults.
+   - **Relationships (in traits)**: in a trait that fabricates a related doc, *always* honour `self.overrides.get("<fk_field>")` before creating a new dependent record (prevents orphans).
+   - **Relationships (in defaults)**: when a required FK has no sensible literal default, use the same `self.overrides.get(...) or RelatedFactory.create().name` short-circuit inside `default_attributes` so callers can pass an existing record without spawning an orphan.
+6. Factory bot owns teardown via `__del__` hooks. Do **not** add manual cleanup of factory-built docs in tearDown.
+7. **Do not override `create()`** to wrap heavy side effects. If a doctype needs more than `frappe.get_doc({...}).insert()` to be usable (parent DocType, DocShare, etc.), build a separate factory for the dependency and reference it from `default_attributes` (see rule 5). Overriding `create()` breaks `build_list` / `create_list` and diverges from the convention.
+8. If a doctype you need has no factory yet, write one first, then write the test. Keep the factory commit / change separate-ish from test logic when reasonable.
+
+## Authoring a factory
+
+Template — replace placeholders. Note the generic `BaseFactory[FooBar]` typing.
+
+```python
+from typing import Any
+
+from faker import Faker
+from frappe_factory_bot.frappe_factory_bot.base_factory import BaseFactory
+
+from forms_pro.forms_pro.doctype.foo_bar.foo_bar import FooBar
+
+_fake = Faker()
+
+
+class FooBarFactory(BaseFactory[FooBar]):
+    doctype = "Foo Bar"
+
+    @property
+    def default_attributes(self) -> dict[str, Any]:
+        from forms_pro.tests.factories.fp_team_factory import FPTeamFactory
+
+        return {
+            "title": _fake.unique.sentence(nb_words=3),
+            "is_active": 1,
+            # Lazy-create the FK only if the caller did not pass one.
+            "owner_team": self.overrides.get("owner_team") or FPTeamFactory.create().name,
+        }
+
+    @property
+    def with_owner_team(self) -> dict[str, Any]:
+        # Same honour-override pattern, applicable to optional FKs surfaced via traits.
+        from forms_pro.tests.factories.fp_team_factory import FPTeamFactory
+
+        return {
+            "owner_team": self.overrides.get("owner_team") or FPTeamFactory.create().name,
+        }
+```
+
+Reference existing factories:
+- `forms_pro/tests/factories/user_factory.py` — `Faker.unique`, `with_forms_pro_role` trait that seeds a child table.
+- `forms_pro/tests/factories/fp_team_factory.py` — minimal default attributes.
+- `forms_pro/tests/factories/user_invitation_factory.py` — overrides-aware defaults + `to_forms_pro_app` trait.
+- `forms_pro/tests/factories/form_factory.py` + `linked_form_doctype_factory.py` — pattern for a doctype with non-trivial dependencies; defaults lazy-create the placeholder DocType and team.
+
+## Gotchas
+
+### `__del_override__` fires on garbage collection
+
+`BaseFactory._attach_del` swaps the returned doc's class so its `__del__` runs cleanup. Python invokes `__del__` when the doc is GC'd. If you chain `Factory.create().name` and discard the doc, the cleanup may run **before** the FK is used downstream, deleting the doc you just relied on.
+
+```python
+# Risky — DocType may be GC'd before the Form insert reads its name.
+fk = MyDocTypeFactory.create().name
+
+# Safe — binding keeps the doc alive for the test's lifetime.
+parent = MyDocTypeFactory.create()
+fk = parent.name
+```
+
+For factories that do not need destructive cleanup (e.g. DocTypes whose unique random names provide isolation), it is acceptable to skip the `__del_override__` override entirely.
+
+### `before_insert` / `validate` can clobber overrides
+
+Some doctypes hard-set fields during `before_insert` (e.g. `Form.before_insert` forces `is_published = False`). Passing `is_published=1` as a factory override is silently overwritten — the override is merged into the dict that becomes the new doc, but `before_insert` runs after that and overwrites the attribute.
+
+Patch post-insert when this matters:
+
+```python
+form = FormFactory.create(...)
+form.is_published = 1
+form.save(ignore_permissions=True)
+```
+
+Rule of thumb: if the doctype hard-sets a field in `before_insert`, `validate`, or `before_validate`, factory overrides cannot reach it — touch the field after `.create()` and save again.
+
+## Consuming factories in tests
+
+```python
+import frappe
+from frappe.tests import IntegrationTestCase
+
+from forms_pro.tests.factories.user_factory import UserFactory
+from forms_pro.tests.factories.fp_team_factory import FPTeamFactory
+
+
+class TestSomething(IntegrationTestCase):
+    def test_invites_existing_member(self) -> None:
+        user = UserFactory.create("with_forms_pro_role")
+        team = FPTeamFactory.create(owner=user.name)
+        # IDE knows `user: User` and `team: FPTeam` thanks to BaseFactory[T].
+        frappe.set_user(user.name)
+        ...
+```
+
+Method cheat sheet (all class methods on the factory):
+
+| Call | Returns | Saved? |
+| --- | --- | --- |
+| `Factory.build(*traits, **overrides)` | `T` | no |
+| `Factory.create(*traits, **overrides)` | `T` | yes |
+| `Factory.build_list(n, *traits, **overrides)` | `list[T]` | no |
+| `Factory.create_list(n, *traits, **overrides)` | `list[T]` | yes |
+
+Precedence: overrides > traits > defaults. Passing a trait that does not exist raises `TypeError`.
+
+## Test runner
+
+```bash
+bench --site forms.dev run-tests --module forms_pro.tests.test_<module>
+```
+
+The command above will run tests inside the module.
+
+If you want to run all tests, you can use the following command:
+
+```bash
+bench --site forms.dev run-tests --app forms_pro
+```
+
+If you want to run a specific test, you can use the following command:
+
+```bash
+bench --site forms.dev run-tests --module *path_to_test_file* --test *test_method_name*
+```

.github/workflows/backport.yml

@@ -0,0 +1,17 @@
+name: Backport
+
+on:
+  pull_request_target:
+    types: [closed, labeled]
+
+jobs:
+  backport:
+    if: github.event.pull_request.merged && contains(join(github.event.pull_request.labels.*.name, ','), 'backport/')
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - uses: korthout/backport-action@v4
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          pull_title: "[backport] ${pull_title}"
+          label_pattern: "^backport/([^ ]+)$"

.github/workflows/ci.yml

@@ -1,6 +1,6 @@
 name: CI
 
-# Deployment branch for Frappe version-15 (Python 3.10, Node 18, MariaDB 10.6.24)
+# Deployment branch for Frappe version-15 (Python 3.10, Node 20, MariaDB 10.6.24)
 on:
   push:
     branches:
@@ -12,7 +12,6 @@ on:
       - version-15
     paths-ignore:
       - ".github/**"
-  merge_group:
 
 concurrency:
   group: version-15-forms_pro-${{ github.event.number }}

.github/workflows/linter.yml

@@ -7,7 +7,6 @@ on:
       - version-15
     paths-ignore:
       - ".github/**"
-  merge_group:
   workflow_dispatch:
 
 permissions:
@@ -21,7 +20,7 @@ jobs:
   linter:
     name: 'Frappe Linter'
     runs-on: ubuntu-latest
-    if: github.event_name == 'pull_request' || github.event_name == 'merge_group'
+    if: github.event_name == 'pull_request'
 
     steps:
       - uses: actions/checkout@v6

.github/workflows/typecheck.yml

@@ -1,6 +1,6 @@
 name: Frontend TypeScript
 
-# Frappe version-15 deployment branch: Node 18
+# Frappe version-15 deployment branch: Node 20
 on:
   push:
     branches:
@@ -14,7 +14,6 @@ on:
     paths:
       - "frontend/**"
       - ".github/workflows/typecheck.yml"
-  merge_group:
 
 concurrency:
   group: typecheck-version-15-forms_pro-${{ github.event.number || github.sha }}

.github/workflows/ui-tests.yml

@@ -1,11 +1,13 @@
 name: UI Tests
 
+# Frappe version-15 deployment branch (Python 3.10, Node 20)
 on:
   push:
     branches:
-      - develop
+      - version-15
   pull_request:
-  merge_group:
+    branches:
+      - version-15
   workflow_dispatch:
 
 concurrency:
@@ -28,7 +30,7 @@ jobs:
         ports:
           - 11000:6379
       mariadb:
-        image: mariadb:10.6
+        image: mariadb:10.6.24
         env:
           MYSQL_ROOT_PASSWORD: root
         ports:
@@ -42,12 +44,12 @@ jobs:
       - name: Setup Python
         uses: actions/setup-python@v6
         with:
-          python-version: "3.14"
+          python-version: "3.10"
 
       - name: Setup Node
         uses: actions/setup-node@v6
         with:
-          node-version: 24
+          node-version: 20
           check-latest: true
 
       - name: Add to Hosts
@@ -90,7 +92,7 @@ jobs:
       - name: Setup Frappe bench
         run: |
           pip install frappe-bench
-          bench init --skip-redis-config-generation --skip-assets --python "$(which python)" ~/frappe-bench
+          bench init ~/frappe-bench --version version-15 --skip-redis-config-generation --skip-assets --python "$(which python)"
           mariadb --host 127.0.0.1 --port 3306 -u root -proot -e "SET GLOBAL character_set_server = 'utf8mb4'"
           mariadb --host 127.0.0.1 --port 3306 -u root -proot -e "SET GLOBAL collation_server = 'utf8mb4_unicode_ci'"
 

.pre-commit-config.yaml

@@ -41,22 +41,11 @@ repos:
               .*boilerplate.*
           )$
 
-  - repo: https://github.com/pre-commit/mirrors-eslint
-    rev: v8.44.0
+  - repo: https://github.com/oxc-project/mirrors-oxlint
+    rev: v1.60.0
     hooks:
-      - id: eslint
-        types_or: [javascript, ts]
-        args: ["--quiet"]
-        # Ignore any files that might contain jinja / bundles
-        exclude: |
-          (?x)^(
-              frontend/components.d.ts|
-              frontend/auto-imports.d.ts|
-              forms_pro/public/frontend/.*|
-              cypress/.*|
-              .*node_modules.*|
-              .*boilerplate.*
-          )$
+      - id: oxlint
+        types_or: [javascript, ts, vue]
 
 ci:
   autoupdate_schedule: weekly

CLAUDE.md

@@ -21,7 +21,7 @@ npm run build
 # TypeScript type check
 cd frontend && yarn typecheck
 
-# Lint & format (BiomeJS)
+# Lint (oxlint) & format (Prettier via pre-commit)
 cd frontend && yarn lint
 ```
 
@@ -107,6 +107,7 @@ When a form is saved, its fields are synced to the linked DocType as `CustomFiel
 | `/release [version]` | Draft a new GitHub release. Inspects merged PRs since the last release, categorizes them, and creates a draft on GitHub for review. |
 | `/add-field <FieldtypeName>` | Add a new field type end-to-end: backend doctype + mapping, submission serialization, frontend component, fieldTypes registry, options resolution, and submission display. |
 | `/userinterface-wiki` | Review UI/UX against best practices — animations, CSS, typography, UX patterns, prefetching, icons. Outputs file:line findings. |
+| `/writing-tests` | Use `frappe_factory_bot` factories under `forms_pro/tests/factories/` for backend test fixtures (never `frappe.new_doc` / `frappe.get_doc`). Covers authoring a typed factory, traits, overrides, and consumption patterns. Auto-applies when writing/modifying tests. |
 
 > **Adding skills via `npx skills`:** Always use `--copy` and target `.claude/skills/` explicitly so Claude Code can discover them:
 > ```bash
@@ -116,8 +117,9 @@ When a form is saved, its fields are synced to the linked DocType as `CustomFiel
 
 ## Key Conventions
 
-- **Python target**: 3.10+; formatted with `ruff`
+- **Python target**: 3.14+; formatted with `ruff`
 - **TypeScript**: strict mode; `vue-tsc` enforced in CI
 - **Frappe patterns**: use `frappe.get_doc`, `frappe.get_all`, `frappe.db.*`; avoid raw SQL unless necessary
 - **PR titles**: validated by CI workflow (conventional commit format expected)
 - **Tests**: use Frappe's `IntegrationTestCase`; test infrastructure set up in `install.py:before_tests()`
+- **Test fixtures**: build documents via factories in `forms_pro/tests/factories/` (powered by `frappe_factory_bot`, repo `harshtandiya/frappe_factory_bot`). Do **not** use `frappe.new_doc` / `frappe.get_doc(...).insert()` in tests. See the `/writing-tests` skill.

forms_pro/api/export/__init__.py

@@ -0,0 +1,3 @@
+from .endpoints import export_submissions
+
+__all__ = ["export_submissions"]