-
Notifications
You must be signed in to change notification settings - Fork 12
chore: hygine #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
chore: hygine #60
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
22616c0
chore: update gitignore and pre-commit config for current project str…
harshtandiya 6c0988b
chore: replace license.txt with LICENSE
harshtandiya 875d237
chore: add community health files and GitHub templates
harshtandiya 0ee29da
docs: update README with contributing and security references
harshtandiya 0e15a42
chore: update Python version references to 3.14 across all configs
harshtandiya 616f9ff
fix: set ruff target-version to py313 (py314 not yet supported)
harshtandiya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| * @buildwithhussain | ||
|
|
||
| /.github/ @buildwithhussain | ||
| /frontend/ @buildwithhussain | ||
| /forms_pro/ @buildwithhussain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| name: Bug report | ||
| description: Report a reproducible problem in Forms Pro | ||
| title: "bug: " | ||
| labels: | ||
| - bug | ||
| body: | ||
| - type: textarea | ||
| id: summary | ||
| attributes: | ||
| label: Summary | ||
| description: What happened, and what did you expect to happen instead? | ||
| placeholder: A clear description of the bug and the expected behavior. | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: steps | ||
| attributes: | ||
| label: Steps to reproduce | ||
| description: Provide the smallest set of steps needed to reproduce the issue. | ||
| placeholder: | | ||
| 1. Go to ... | ||
| 2. Click ... | ||
| 3. See error ... | ||
| validations: | ||
| required: false | ||
| - type: textarea | ||
| id: environment | ||
| attributes: | ||
| label: Environment | ||
| description: Share the app, Frappe, browser, and deployment details that matter. | ||
| placeholder: Forms Pro version, Frappe version, browser, site setup, and any relevant logs. | ||
| validations: | ||
| required: false | ||
| - type: textarea | ||
| id: additional_context | ||
| attributes: | ||
| label: Additional context | ||
| description: Add screenshots, tracebacks, or anything else that helps. | ||
| validations: | ||
| required: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| name: Feature request | ||
| description: Suggest an improvement or new capability for Forms Pro | ||
| title: "feat: " | ||
| labels: | ||
| - enhancement | ||
| body: | ||
| - type: textarea | ||
| id: problem | ||
| attributes: | ||
| label: Problem or opportunity | ||
| description: What problem are you trying to solve? | ||
| placeholder: Describe the workflow gap, limitation, or use case. | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: proposal | ||
| attributes: | ||
| label: Proposed solution | ||
| description: Describe the change you would like to see. | ||
| placeholder: Explain the feature, expected behavior, and any UX details that matter. | ||
| validations: | ||
| required: false | ||
| - type: textarea | ||
| id: alternatives | ||
| attributes: | ||
| label: Alternatives considered | ||
| description: Describe any workarounds or alternative approaches you have tried. | ||
| validations: | ||
| required: false | ||
| - type: textarea | ||
| id: additional_context | ||
| attributes: | ||
| label: Additional context | ||
| description: Add mockups, links, screenshots, or other supporting details. | ||
| validations: | ||
| required: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: pip | ||
| directory: / | ||
| schedule: | ||
| interval: weekly | ||
| labels: | ||
| - dependencies | ||
|
|
||
| - package-ecosystem: yarn | ||
| directory: /frontend | ||
| schedule: | ||
| interval: weekly | ||
| labels: | ||
| - dependencies | ||
| - frontend | ||
|
|
||
| - package-ecosystem: github-actions | ||
| directory: / | ||
| schedule: | ||
| interval: weekly | ||
| labels: | ||
| - dependencies | ||
| - ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ## Summary | ||
|
|
||
| - Describe the change and the reason for it. | ||
|
|
||
| ## Testing | ||
|
|
||
| - [ ] `pre-commit run --all-files` | ||
| - [ ] `cd frontend && yarn typecheck` | ||
| - [ ] `bench --site <site> run-tests --app forms_pro` | ||
|
|
||
| ## Checklist | ||
|
|
||
| - [ ] PR title follows the conventional format used by this repo | ||
| - [ ] Documentation updated if behavior or setup changed | ||
| - [ ] Screenshots attached for UI changes when useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Contributing to Forms Pro | ||
|
|
||
| Thanks for contributing to `forms_pro`. | ||
|
|
||
| ## Getting Started | ||
|
|
||
| 1. Fork the repository and create a branch from `develop`. | ||
| 2. Install the app in your Bench environment. | ||
| 3. Install local checks: | ||
|
|
||
| ```bash | ||
| pre-commit install | ||
| ``` | ||
|
|
||
| ## Local Checks | ||
|
|
||
| Run the checks relevant to your change before opening a pull request. | ||
|
|
||
| ```bash | ||
| pre-commit run --all-files | ||
| cd frontend && yarn typecheck | ||
| bench --site <site> run-tests --app forms_pro | ||
| ``` | ||
|
|
||
| ## Pull Requests | ||
|
|
||
| - Keep changes focused and easy to review. | ||
| - Include a short summary of what changed and why. | ||
| - Add screenshots for UI changes when helpful. | ||
| - Use a conventional PR title such as `fix: handle empty submission state`. | ||
|
|
||
| ## Security | ||
|
|
||
| If you find a security issue, do not open a public issue. Follow the process in [`SECURITY.md`](SECURITY.md). | ||
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Security Policy | ||
|
|
||
| ## Supported Versions | ||
|
|
||
| Security fixes are currently targeted at the active `develop` branch. | ||
|
|
||
| | Version | Supported | | ||
| | --- | --- | | ||
| | `develop` | Yes | | ||
|
|
||
| ## Reporting a Vulnerability | ||
|
|
||
| Please report vulnerabilities privately to [developers@buildwithhussain.com](mailto:developers@buildwithhussain.com). | ||
|
|
||
| - Do not open a public GitHub issue for security reports. | ||
| - Include clear reproduction steps, impact, and any suggested mitigations if you have them. | ||
| - We will review the report, confirm the issue, and coordinate a fix and disclosure timeline with you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,5 @@ dist | |
| dist-ssr | ||
| *.local | ||
| coverage | ||
| ../<app-name> | ||
| sites | ||
| src/types/frappe-ui.d.ts | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run checks without changing cwd for later commands.
After Line 21, the shell remains in
frontend, so Line 22 may fail or run in the wrong location. Wrap the frontend check in a subshell (or addcd ..) sobenchruns from the expected root context.Suggested doc fix
🤖 Prompt for AI Agents