feat: manage form pages

.github/workflows/ci.yml

@@ -46,12 +46,12 @@ jobs:
       - name: Setup Python
         uses: actions/setup-python@v4
         with:
-          python-version: '3.10'
+          python-version: "3.14"
 
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version: 24
           check-latest: true
 
       - name: Cache pip
@@ -96,7 +96,7 @@ jobs:
           bench --site test_site install-app forms_pro
           bench build
         env:
-          CI: 'Yes'
+          CI: "Yes"
 
       - name: Run Tests
         working-directory: /home/runner/frappe-bench

.pre-commit-config.yaml

@@ -30,7 +30,7 @@ repos:
     rev: v2.7.1
     hooks:
       - id: prettier
-        types_or: [javascript, vue, scss]
+        types_or: [javascript, vue, scss, ts]
         # Ignore any files that might contain jinja / bundles
         exclude: |
           (?x)^(
@@ -45,7 +45,7 @@ repos:
     rev: v8.44.0
     hooks:
       - id: eslint
-        types_or: [javascript]
+        types_or: [javascript, ts]
         args: ["--quiet"]
         # Ignore any files that might contain jinja / bundles
         exclude: |

forms_pro/api/form.py

@@ -1,4 +1,20 @@
 import frappe
+from frappe import _
+from frappe.share import remove
+from pydantic import BaseModel, Field
+
+from forms_pro.api.user import get_user
+from forms_pro.forms_pro.doctype.form.form import Form
+
+
+class FormSharedWithResponse(BaseModel):
+    full_name: str
+    user_image: str | None
+    email: str = Field(alias="user")
+    read: bool
+    write: bool
+    share: bool
+    submit: bool
 
 
 @frappe.whitelist(allow_guest=True)
@@ -9,7 +25,7 @@ def get_form_by_route(route: str) -> dict:
 
 @frappe.whitelist(allow_guest=True)
 def get_form(form_id: str) -> dict:
-    form = frappe.get_doc(
+    form: Form = frappe.get_doc(
         "Form",
         form_id,
     )
@@ -24,6 +40,66 @@ def get_form(form_id: str) -> dict:
     }
 
 
+@frappe.whitelist()
+def get_form_shared_with(form_id: str) -> list[frappe.Any]:
+    """
+    Get list of users with which a form is shared.
+
+    We validate the current user has read access to the form.
+    """
+    if not frappe.has_permission(
+        "Form",
+        "read",
+        form_id,
+    ):
+        frappe.throw(_("You do not have read access to this form"))
+
+    form: Form = frappe.get_doc("Form", form_id)
+    shared_with = form.shared_with()
+
+    shared_with_responses = []
+
+    for user in shared_with:
+        _user = get_user(user["user"])
+        user.update(_user)
+        shared_with_responses.append(FormSharedWithResponse.model_validate(user).model_dump())
+
+    return shared_with_responses
+
+
+@frappe.whitelist()
+def remove_form_access(form_id: str, user_email: str) -> None:
+    """
+    Remove access to a form for a user.
+
+    We validate the current user has write access to the form.
+
+    args:
+        form_id: str - The ID of the form to remove access to.
+        user_email: str - The email of the user to remove access to.
+
+    """
+
+    if not frappe.has_permission("Form", "write", form_id):
+        frappe.throw(_("You do not have write access to this form"))
+
+    return remove(doctype="Form", name=form_id, user=user_email, flags={"ignore_permissions": True})
+
+
+@frappe.whitelist()
+def get_doctype_list() -> list[str]:
+    if not frappe.has_permission("DocType", "read"):
+        frappe.throw(_("You do not have read access to this doctype"))
+
+    return frappe.db.get_list(
+        "DocType",
+        filters={"istable": 0},
+        pluck="name",
+        order_by="name",
+        limit_page_length=99999,
+    )
+
+
 @frappe.whitelist()
 def get_doctype_fields(doctype: str) -> dict:
     doctype = frappe.get_doc("DocType", doctype)
@@ -43,14 +119,3 @@ def get_doctype_fields(doctype: str) -> dict:
     fields = [field for field in fields if field.fieldtype not in FIELDTYPES_TO_REMOVE]
 
     return fields
-
-
-@frappe.whitelist()
-def get_doctype_list() -> list[str]:
-    return frappe.db.get_list(
-        "DocType",
-        filters={"istable": 0},
-        pluck="name",
-        order_by="name",
-        limit_page_length=99999,
-    )

forms_pro/api/team.py

@@ -1,5 +1,6 @@
 import frappe
 
+from forms_pro.forms_pro.doctype.fp_team.fp_team import FPTeam, GetTeamMembersResponse
 from forms_pro.utils.teams import GetTeamFormsResponseSchema
 from forms_pro.utils.teams import get_team_forms as get_team_forms_utils
 
@@ -17,3 +18,26 @@ def get_team_forms(team_id: str) -> list[GetTeamFormsResponseSchema]:
     """
     forms = get_team_forms_utils(team_id=team_id)
     return forms
+
+
+@frappe.whitelist()
+def get_team_members(team_id: str) -> list[GetTeamMembersResponse]:
+    """
+
+    Get the list of team members in a FP Team.
+    This endpoint checks if the session user has the permission to read this FP Team DocType
+
+    """
+    frappe.has_permission(
+        doctype="FP Team",
+        ptype="read",
+        doc=team_id,
+        user=frappe.session.user,
+        throw=True,
+    )
+    print("team_id", team_id)
+
+    team: FPTeam = frappe.get_doc("FP Team", team_id)
+    members = team.team_members
+
+    return members

forms_pro/api/user.py

@@ -30,8 +30,22 @@ def extract_roles(cls, v: list[HasRole]) -> list[str]:
         return [role.role for role in v]
 
 
+class GetUserBasicResponse(BaseModel):
+    full_name: str
+    user_image: str | None = None
+
+
+@frappe.whitelist()
+def get_user(user: str) -> GetUserBasicResponse | None:
+    """Get basic user data for a given user"""
+    data = frappe.db.get_value("User", user, ["full_name", "user_image"], as_dict=True)
+    if not data:
+        return None
+    return GetUserBasicResponse.model_validate(data).model_dump()
+
+
 @frappe.whitelist()
-def get_user() -> GetUserResponseSchema:
+def get_current_user() -> GetUserResponseSchema:
     """
     Get Current User Data
     """

forms_pro/forms_pro/doctype/form/form.py

@@ -1,8 +1,11 @@
 # Copyright (c) 2025, harsh@buildwithhussain.com and contributors
 # For license information, please see license.txt
 
+from typing import Any
+
 import frappe
 from frappe.model.document import Document
+from frappe.share import get_users
 
 
 class Form(Document):
@@ -34,6 +37,14 @@ class Form(Document):
     def linked_doctype_doc(self) -> Document:
         return frappe.get_doc("DocType", self.linked_doctype)
 
+    @frappe.whitelist()
+    def shared_with(self) -> list[dict[str, Any]]:
+        """
+        Get list of users with which this form is shared
+        """
+        users_shared_with = get_users(self.doctype, self.name)
+        return users_shared_with
+
     def generate_initial_route(self) -> str:
         return "s/forms_pro_" + frappe.utils.random_string(8)
 

forms_pro/forms_pro/doctype/fp_team/fp_team.py

@@ -3,6 +3,16 @@
 
 # import frappe
 from frappe.model.document import Document
+from frappe.utils import cached_property
+from pydantic import BaseModel, EmailStr
+
+from forms_pro.api.user import get_user
+
+
+class GetTeamMembersResponse(BaseModel):
+    full_name: str
+    user_image: str | None
+    email: EmailStr
 
 
 class FPTeam(Document):
@@ -20,15 +30,25 @@ class FPTeam(Document):
         users: DF.TableMultiSelect[FPTeamMember]
     # end: auto-generated types
 
-    @property
-    def team_members(self) -> list[str]:
+    @cached_property
+    def team_members(self) -> list[GetTeamMembersResponse]:
         """
         Get the list of team members
 
         Returns:
             list[str] - List of team member email addresses
         """
-        return [member.user for member in self.users] if self.users else []
+        if not len(self.users):
+            return []
+
+        members = []
+
+        for member in self.users:
+            _user = get_user(member.user)
+            _user["email"] = member.user
+            members.append(GetTeamMembersResponse.model_validate(_user).model_dump())
+
+        return members
 
     def is_team_member(self, user: str) -> bool:
         """

forms_pro/modules.txt

@@ -1 +1,2 @@
-Forms Pro
+Forms Pro
+User Forms