Skip to content

ci: fix semgrep for #4 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NagariaHussain merged 1 commit into from
Oct 10, 2025
Merged

ci: fix semgrep for #4 #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ls_shop/install_demo_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ def install_demo_data():
print(" - Brake System")
print(" - Interior Accessories")
print("\n")

frappe.db.commit() # nosemgrep: manual commit required for demo data installation completion
# nosemgrep: manual commit required for demo data installation completion
frappe.db.commit()

except Exception as e:
frappe.db.rollback()
Expand Down Expand Up @@ -143,7 +143,8 @@ def ensure_attribute_values(attribute_name, values, numeric=False):
}
)
attr.insert(ignore_permissions=True)
frappe.db.commit() # nosemgrep: manual commit required for attribute creation in demo data
# nosemgrep: manual commit required for attribute creation in demo data
frappe.db.commit()
print(f" ✓ {attribute_name} attribute created")
else:
# Attribute exists, just print message
Expand Down
4 changes: 2 additions & 2 deletions ls_shop/publish_demo_items.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ def publish_all_demo_items():
else:
frappe.db.set_value("Website Item", wi.name, "route", item_code)
routed += 1

frappe.db.commit() # nosemgrep: manual commit required for demo item publishing completion
# nosemgrep: manual commit required for demo item publishing completion
frappe.db.commit()
frappe.clear_cache()

print("\n✅ Complete!")
Expand Down