feat: YouTube upload integration#112
Merged
Merged
Conversation
…sing Connect a YouTube account via OAuth in Settings, then upload videos directly from the review page. Uses Frappe's Connected App for token management with auto-refresh. Uploads run as background jobs (R2 download → YouTube resumable upload) with status polling and realtime progress. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ect URI Google OAuth rejects redirect URIs with spaces. The Connected App name becomes part of the Frappe callback URL, so it must be URL-safe. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Frappe auto-generates Connected App names (hash IDs), so we can't hardcode a name. Now stores the generated name in VMS Settings (youtube_connected_app field). Also shows the redirect URI to the user before redirecting to Google, so they can register it first. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use set_name="vms-youtube" to force a predictable name so the redirect URI is known before the user creates their OAuth client. The settings UI now shows the redirect URI as step 1, then asks for credentials as step 2 — no more chicken-and-egg problem. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Show inline progress bar with percentage in upload dialog instead of closing immediately after starting upload - Dialog now has 4 states: form, in-progress, complete, error - Use realtime events (useFrappeEventListener) for instant progress updates with fallback 5s polling for reliability - Remove doctype/docname scoping from publish_realtime calls so events reach the site room that useFrappeEventListener listens on - Switch YouTube job queue from "long" to "default" (no long worker in Procfile) - Remove duplicate import requests in youtube.py Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add ClassVar annotation to mutable class attrs in search.py (RUF012) - Exclude vms/public/frontend/ from prettier and eslint pre-commit hooks - Auto-format Python files via ruff Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
These files change on every frontend build and create noisy diffs. Static assets (icons, fonts, logo) remain tracked. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frappe.publish_realtime. Complete state shows clickable YouTube badge. Error state offers retry. Re-upload resets status.Files
vms/youtube.pyfrontend/.../YouTubeSection.tsxfrontend/.../YouTubeUploadDialog.tsxvms/.../vms_settings.jsonvms/.../vms_asset.jsonSettingsDialog.tsxReviewHeader.tsxReviewPage.tsxreview_api.pyTest plan
🤖 Generated with Claude Code