Explain and resolve incomplete Builder source hydration - #3377
Draft
3mdistal wants to merge 1 commit into
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Builder-backed Content imports could finish with generic
unavailablebodies even when the exact Builder entry still existed and intentionally contained no visual blocks. The retry loop erased the distinction between an empty body, a missing entry, permissions, transient reads, malformed payloads, and conversion failures, leaving users and operators without an actionable terminal reason.Approach
Introduce a feature-flagged outcome contract at the exact Builder body-read boundary. A provider-confirmed empty body is a successful hydrated result. Every actual failure retains a typed reason, provider status, attempt count, and retryability; transient failures use bounded backoff, while changed upstream source data resets the retry schedule. The feature is off by default under
content.builder-body-hydration-reasons.What changed
next_attempt_atfor honest retry scheduling.Product impact
content.feature.connect-your-sourcescontent.source.adaptersSafety and operations
content.builder-body-hydration-reasons; the new evidence columns can remain safely in place.main. This draft PR does not merge, deploy, or change production flags.Verification
pnpm --filter content typecheckpasses (with expected local-production database configuration warnings).pnpm guardspasses all 63 repository guards.Review focus