Conversation
| export interface selection { | ||
| /** A byte. */ | ||
| id: number | ||
| name?: string | ||
| startX: number | ||
| startY: number | ||
| startZ: number | ||
| endX: number | ||
| endY: number | ||
| endZ: number | ||
| /** A color component of 0 to 255. */ | ||
| red?: number | ||
| /** A color component of 0 to 255. */ | ||
| green?: number | ||
| /** A color component of 0 to 255. */ | ||
| blue?: number | ||
| /** The opacity from 0 to 255. 255 is fully opaque. */ | ||
| opacity?: number | ||
| } |
There was a problem hiding this comment.
idk should a class be made? classicborne uses arrays for positions but classicborne-server-protocol uses object fields wizh varying names.
but also, classicborne-server-protocol isn't too low-level, it does prefer floats over fixed-points. Color is sort of fixed point, right? maybe it should instead be 0-1? but whatever. follow what block definition does for fog colors for now
📝 WalkthroughWalkthroughA new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
|
Note Docstrings generation - SUCCESS |
Docstrings generation was requested by @BunnyNabbit. * #39 (comment) The following files were modified: * `class/Server.mjs`
|



Resolves #5
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.