Adding idotless to feature GSUB & updating license URL strings to match current requirements#55
Open
aaronbell wants to merge 4 commits intoButTaiwan:mainfrom
Open
Adding idotless to feature GSUB & updating license URL strings to match current requirements#55aaronbell wants to merge 4 commits intoButTaiwan:mainfrom
aaronbell wants to merge 4 commits intoButTaiwan:mainfrom
Conversation
No need to update GF for these, but the update will be needed downstream for bpmf.
Contributor
Author
|
@ButTaiwan I discovered that /idotless was not included in the feature code for the tone marks, which was causing issues when /idotless is used instead of /i in text. For example, in these sample texts: https://en.wikipedia.org/wiki/T%C3%A2i-u%C3%A2n_L%C3%B4-m%C3%A1-j%C4%AB_Phing-im_Hong-%C3%A0n#Sample_texts If this all looks good, we can PR the new version. |
aaronbell
changed the title
Contributor
Author
Fixed this up too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to update GF for these, but the update will be needed downstream for bpmf.
Fixes #54 – fixed this bug in the build source.