[TEST] bugfix/ladybug — support knowledgeIds scoping and optimize query execution - #135
Open
bharatsachya wants to merge 2 commits into
Open
bharatsachya wants to merge 2 commits into
bharatsachya wants to merge 2 commits into
Conversation
Contributor
Author
|
Against #136 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodeTables,relTables) and theensureSchemafunction out of client.ts and into a new, dedicated schema module schema.ts.knowledgeIdsScoping for Ladybug Searches:knowledgeId IN $knowledgeIdswhen an array of allowed knowledgebase IDs is provided.$knowledgeIdsparameter is only bound when the query uses the filter condition, preventing engine errors from unused parameters.closeLadybugin client.ts to clear the prepared statements cache (preparedCache) and properly close and await the release of native DB and Connection handles. This resolves issues with locked database files on disk._runCypherOnce):_runCypherOncein client.ts to execute unique/one-off query statements without caching their compiled plans.bulkUpsertFilesin files.ts to runCOPY File FROM '<temp path>'commands via_runCypherOnce. Since the temporary paths are unique per invocation, this prevents memory leaks caused by caching infinite unique prepared statements.setKnowledgeBranchInGraphandvacuumOrphanEntities.Why
ConceptGraphStrategyenrichment utilizes Neo4j by querying with aknowledgeIdsarray scope (defaulting to the current knowledge base ID, withknowledgeIdset tonull). Without supporting this allowlist scoping in LadybugDB's query builder, search operations would either run completely unscoped (across all repos) or fail, resulting in incorrect results or exceptions.COPY File FROM ...) leaks memory. By running them through_runCypherOnce, the statements are compiled, executed, and garbage-collected without populating thepreparedCache.How to test
knowledgeIdswith LadybugDB active as the graph provider. Ensure results are filtered correctly to only match target knowledge bases and that the query engine does not reject parameters.preparedCachedoes not bloat or contain uniqueCOPY File FROMquery templates.Screenshots
Backend-only changes. No UI was affected.