fix(cli): report call status start as unknown - #138
Open
Arshgill01 wants to merge 1 commit into
Open
Arshgill01 wants to merge 1 commit into
Arshgill01 wants to merge 1 commit into
Conversation
call status reused callStarted: true on every error envelope, including auth_required on a machine that never placed a call. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
calle call statusnow passescallStarted: "unknown"into the error envelope (the same tri-statecall startalready uses for ambiguity), instead of a literaltrue.cli-reference.mdnow states that a status-lookup failure cannot know whether a call exists, and thattrueis reserved for a stablerun_idfromrun_call.Why
The CLI reference defines
call_started: trueas:run_callreturned a stablerun_id.call statusreused the stage helper withcallStarted: true, so a fresh machine with no token reported that a call had been started:No call was started; the command never reached the server with credentials.
retry_safe: truestays correct (read-only).Evidence
Unit test, fake cache, no network, no phone call.
call_startedis"unknown", nottrue.Test
pnpm --filter @call-e/cli test:unitandpnpm --filter @call-e/cli check.Release decision
Patch release recommended for
@call-e/cli. Changeset included. Fixes documented error-envelope guidance; no new flag.Source
From the CALL-E hackathon feedback lab: https://github.com/Arshgill01/ExactRef/blob/main/docs/feedback/lab/XR-609-call-status-hardcodes-call-started-true.md
Made with Cursor