Add smart conversion mode#57
Open
CosmicElysium wants to merge 28 commits into
Open
Conversation
Still possible race conditions present. Need to do further testing.
This reverts commit da061ef.
Still need to debug statsZ as the current statsZ region has race conditions as a shared variable in the parallel for loop
Contributor
Author
|
EDIT: fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a smart converter option.
This is accessed with a "-r" flag plus an optional integer that indicates max memory allocation in MB (for example, -r2000 for 2 GB limit). If no number is indicated, then the fast mode is used as the assumption is that memory is not an issue for the user.
Currently, the memory allocation must be enough to hold the area of a chunk times the depth of the cube. Otherwise, the user receives an error, and the minimum memory is suggested.
The included converter tests also now include a way to test the smart converter option.
Important thing to note: this is a branch from the 3D mipmap calculation branch, so it includes the changes from PR #53
Closes #44