Update colormap names to match Matplotlib's definitions#12
Closed
izkgao wants to merge 1 commit into
Closed
Conversation
12 tasks
Contributor
|
@izkgao The file you're modifying here is the legacy v1 preferences schema, which is no longer used and should not be modified. The current preferences schema ( We only use the schema to validate the field type, and rely on the frontend to manage permitted values, because our available selection is essentially arbitrary, and we shouldn't have to change the schema to add / remove colormaps. This is consistent with what we decided to do with certain numeric limits which are also arbitrary and subject to change, e.g. various data sizes. However, I have more remarks about the frontend PR, which I will make there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the colormap names in the preference schema to match Matplotlib's definitions.
Companion frontend PR: CARTAvis/carta-frontend#2629.