Skip to content

Update colormap names to match Matplotlib's definitions#12

Closed
izkgao wants to merge 1 commit into
mainfrom
zhenkai/2628_schemas_correct_colormaps
Closed

Update colormap names to match Matplotlib's definitions#12
izkgao wants to merge 1 commit into
mainfrom
zhenkai/2628_schemas_correct_colormaps

Conversation

@izkgao
Copy link
Copy Markdown

@izkgao izkgao commented Nov 28, 2025

This PR updates the colormap names in the preference schema to match Matplotlib's definitions.
Companion frontend PR: CARTAvis/carta-frontend#2629.

@confluence
Copy link
Copy Markdown
Contributor

@izkgao The file you're modifying here is the legacy v1 preferences schema, which is no longer used and should not be modified. The current preferences schema (preferences_schema_2.json) doesn't restrict colormap fields to specific values, so no change is required.

We only use the schema to validate the field type, and rely on the frontend to manage permitted values, because our available selection is essentially arbitrary, and we shouldn't have to change the schema to add / remove colormaps. This is consistent with what we decided to do with certain numeric limits which are also arbitrary and subject to change, e.g. various data sizes.

However, I have more remarks about the frontend PR, which I will make there.

@izkgao izkgao closed this Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants