fix: Make --quiet flag work again #1970
Merged
+35
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --quiet flag was broken due to two issues: 1. Inverted mapping in Rust FFI: The C→Rust constant mapping was wrong. CCX_MESSAGES_QUIET=0, CCX_MESSAGES_STDOUT=1, CCX_MESSAGES_STDERR=2 but the Rust code mapped 0→Stdout, 1→Stderr, 2→Quiet. 2. Logger initialization timing: The Rust logger was initialized BEFORE command-line arguments were parsed, so --quiet had no effect. Changes: - Fix the OutputTarget mapping in ccxr_init_basic_logger() - Add set_target() method to CCExtractorLogger - Add ccxr_update_logger_target() to update logger after arg parsing - Call ccxr_update_logger_target() after ccxr_parse_parameters() Fixes #1956 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit a5b8bc8...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit a5b8bc8...:
Your PR breaks these cases:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
--quietflag was broken in version 0.96, causing output to still be printed even when the flag was specified.Root causes:
Inverted mapping in Rust FFI: The C→Rust constant mapping was wrong.
CCX_MESSAGES_QUIET=0, CCX_MESSAGES_STDOUT=1, CCX_MESSAGES_STDERR=2but the Rust code mapped0→Stdout, 1→Stderr, 2→Quiet.Logger initialization timing: The Rust logger was initialized BEFORE command-line arguments were parsed, so
--quiethad no effect on the logger's target.Changes:
OutputTargetmapping inccxr_init_basic_logger()set_target()method toCCExtractorLoggerto allow updating after initializationccxr_update_logger_target()FFI function to update logger after arg parsingccxr_update_logger_target()afterccxr_parse_parameters()in mainTest plan
--quietnow produces no output--quietFixes #1956
🤖 Generated with Claude Code