Skip to content

Fix TimerRingController async misuse and null-safe vibration cleanup (Fixes #854) #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Santhoshkumargontla wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix TimerRingController async misuse and null-safe vibration cleanup (Fixes #854) #859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions lib/app/modules/timerRing/controllers/timer_ring_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,14 @@ class TimerRingController extends GetxController {
MethodChannel timerChannel = const MethodChannel('timer');
Timer? vibrationTimer;
late StreamSubscription<FGBGType> _subscription;
getFakeTimerModel()async {
TimerModel fakeTimer = await Utils.genFakeTimerModel();
return fakeTimer;

Future<TimerModel> getFakeTimerModel() async {
TimerModel fakeTimer = await Utils.genFakeTimerModel();
return fakeTimer;
}

@override
void onInit() async {
Future<void> onInit() async {
super.onInit();

// Preventing app from being minimized!
Expand All @@ -30,17 +32,19 @@ class TimerRingController extends GetxController {
Timer.periodic(const Duration(milliseconds: 3500), (Timer timer) {
Vibration.vibrate(pattern: [500, 3000]);
});
AudioUtils.playTimer(alarmRecord: await getFakeTimerModel().value);
final timerRecord = await getFakeTimerModel();
AudioUtils.playTimer(alarmRecord: timerRecord);

await timerChannel.invokeMethod('cancelTimer');
}

@override
onClose() async {
Future<void> onClose() async {
Vibration.cancel();
vibrationTimer!.cancel();
vibrationTimer?.cancel();
final timerRecord = await getFakeTimerModel();
AudioUtils.stopTimer(
ringtoneName: await getFakeTimerModel().ringtoneName,
ringtoneName: timerRecord.ringtoneName,
);
_subscription.cancel();
super.onClose();
Expand Down