Skip to content
This repository was archived by the owner on Apr 27, 2022. It is now read-only.

Docker for BMI#93

Open
chemistry-sourabh wants to merge 8 commits intoCCI-MOC:masterfrom
chemistry-sourabh:Docker
Open

Docker for BMI#93
chemistry-sourabh wants to merge 8 commits intoCCI-MOC:masterfrom
chemistry-sourabh:Docker

Conversation

@chemistry-sourabh
Copy link
Contributor

@chemistry-sourabh chemistry-sourabh commented Mar 24, 2017

Docker scripts for BMI and HIL for dev environment #108

@chemistry-sourabh
Copy link
Contributor Author

@CCI-MOC/bmi-breakers try it out!!

@ravisantoshgudimetla
Copy link
Contributor

@chemistry-sourabh Create a wiki instead of PR.

@chemistry-sourabh
Copy link
Contributor Author

Did you mean the Readme file as a wiki ? or the Dockerfile ? because making the latter a wiki doesn't make sense

@ravisantoshgudimetla
Copy link
Contributor

Either way is fine but PR doesn't make sense.

@chemistry-sourabh
Copy link
Contributor Author

@ravisantoshgudimetla what do you mean doesn't make sense ?

@ravisantoshgudimetla
Copy link
Contributor

So, do you want this to be used for setting up BMI, if yes raise an issue and write documentation on how to use it.(This could be in alternate ways to install BMI). Even if this goes into repo, the location has to be decided where this has to stay in repo, without that this PR staying here, doesn't make sense.

@chemistry-sourabh
Copy link
Contributor Author

@ravisantoshgudimetla Ya in the future this can be an easier deployment option for people who use something like kubernetes or docker swarm, etc. For now this just sets up a dev environment for easy deployment on the local system. I am using it on a regular basis and is faster than using a VM on kaizen.

I attached a docker.md with instructions on setting it up. I asked people to give it a try, but nobody did :(, Also typically all the docker files go in the root of the project as docker builds the context of the directories below when building images.

We can later upload it to a MOC docker registry (if it exists)

@ravisantoshgudimetla
Copy link
Contributor

You can upload to docker hub as of now, if I am not mistaken, everyone should be able to access it if you give privileges. @akshayakhare has created a openshift registry, if I am not mistaken again, we can try uploading there. There is no need to use docker swarm or kubernetes unless we want the software to be container grade in production usage. We can use it quick development setup. I recommend you to write a clear README and add it to dev guide. I can test this over next weekend. This is really cool.

@naved001
Copy link
Contributor

naved001 commented Jul 7, 2017

@ravisantoshgudimetla should we have this in an examples/bmi-docker/ directory in the main repo?

@chemistry-sourabh
Copy link
Contributor Author

@naved001 add what to examples ?

@naved001
Copy link
Contributor

add what to examples ?

The scripts in this PR aren't really part of the main BMI code which is why I think it should be in a different folder.

@ravisantoshgudimetla
Copy link
Contributor

Let's add a contrib folder in root and tell developers that this is supported way to do development.

@chemistry-sourabh
Copy link
Contributor Author

I am planning on writing a start dev env script using docker-compose (which I learnt about recently). Also I am thinking of submitting a better version of the run tests script to this PR.

@ravisantoshgudimetla @naved001 let me know more stuff which may be required.

@naved001 naved001 changed the base branch from dev to master September 8, 2017 12:05
@apoorvemohan
Copy link
Collaborator

@chemistry-sourabh can we close this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants