Fixes to generated J2735 from asn1c updates#47
Merged
Conversation
Prepare release notes for 2025 Q2 release
Address comments on USDOT PR 67
Introduce HTTP API for J2735 decoding, PCAP batch support, and jackknife fix
… -fno-include-deps
John-Wiens
approved these changes
Jul 2, 2025
John-Wiens
left a comment
John-Wiens
left a comment
There was a problem hiding this comment.
Looks good to me. I will need to pull in some of these changes into the CV-MEC ASN.1 build system to match as well. However, I don't anticipate this directly breaking anything in that application since they are fairly disconnected from one another.
dmccoystephenson
approved these changes
Jul 7, 2025
dmccoystephenson
left a comment
dmccoystephenson
left a comment
There was a problem hiding this comment.
Looks good! Unit tests pass, program starts up correctly and encoding/decoding works!
Notes:
- I did not test re-generating the files.
- I decoded a couple BSMs.
- I encoded a TIM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several issues to allow generating the J2735/2024 and 2020 C code directly from the ASN.1 files downloaded from SAE with no edits to the ASN.1, and no overrides to the generated C code.
Uses the asn1c compiler from the current
developbranch of the usdot repo as of 6/30/2025:https://github.com/usdot-fhwa-stol/usdot-asn1c/tree/develop
to regenerate the 2024 and 2020 specifications.
Addresses the following issues:
GeneralizedTime.ccode file would not compile on AlpineHAVE_TM_GMTOFFpreprocessor flag-fno-include-deps)-fcase-insensitive-filenamesflag to fix without changing any type names in the specification.