Skip to content

Intersection API Email Generation and Templating#258

Merged
jacob6838 merged 49 commits intodevelopfrom
intersection-api-email-generation-1
Mar 18, 2026
Merged

Intersection API Email Generation and Templating#258
jacob6838 merged 49 commits intodevelopfrom
intersection-api-email-generation-1

Conversation

@jacob6838
Copy link
Copy Markdown
Collaborator

PR Details

Description

Adding email generation and templating to the intersection API:

  • Creating html email template
  • Using thymeleaf templating engine to inject contents into email template
  • Adding email sending brokers for SMTP, Postmark, and SendGrid
  • Storing email subscription data in postgres
  • Generating authenticated unsubscribe links within emails
  • Creating email generator for intersection notification summaries

How Has This Been Tested?

This has been tested using the now included smtp server (in the intersection docker-compose), which can be started by adding the profile "smtp4dev"
Then, use the /emails/send-intersection-notification-summary endpoint with some sample notifications to send an email to the default subscribed user, test@gmail.com
intersection_notification_summary_example

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • My changes require new environment variables:
    • I have updated the docker-compose, K8s YAML, and all dependent deployment configuration files.
  • My changes require updates to the documentation:
    • I have updated the documentation accordingly.
  • My changes require updates and/or additions to the unit tests:
    • I have modified/added tests to cover my changes.
  • All existing tests pass.

@jacob6838 jacob6838 marked this pull request as ready for review January 12, 2026 15:29
Copy link
Copy Markdown
Collaborator

@John-Wiens John-Wiens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor cleanup things. Otherwise looks good.

Comment thread docker-compose-intersection.yml
Comment thread docker-compose-intersection.yml
@jacob6838 jacob6838 requested a review from John-Wiens January 14, 2026 22:29
Copy link
Copy Markdown

@mcook42 mcook42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall I'm really liking the refactors. I have a few blockers so far. I'll keep reviewing the rest tomorrow

Comment thread services/intersection-api/api/pom.xml
Comment thread services/intersection-api/api/src/main/resources/application.yaml Outdated
Comment thread services/intersection-api/api/src/main/resources/templates/emails/README.md Outdated
@jacob6838 jacob6838 merged commit 3a5c9fc into develop Mar 18, 2026
10 checks passed
@jacob6838 jacob6838 deleted the intersection-api-email-generation-1 branch March 18, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants