ci(docs): let a manual dispatch actually deploy the site - #5
Merged
Conversation
Both the artifact upload and the deploy job were gated on `github.event_name == 'push'`, so a workflow_dispatch built the docs and then threw them away. The go-public script dispatches docs.yml precisely because the flip is not a push, which meant Pages could never come up that way — https://cemm2.github.io/AKMS/ is currently 404 with the deploy job reporting `skipped`. docs.yml also carries `paths:` filters on push, so an unrelated commit to main does not trigger it either. Without a dispatch path there is no way to redeploy the site on demand at all. Gate on the ref first so a dispatch from a feature branch cannot publish itself over the released docs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TcdE6eeSDBh8xrgKCoGrkw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://cemm2.github.io/AKMS/returns 404. The site has never deployed.The most recent
Documentationrun (dispatched by08_go_public.shrightafter the public flip) is green, but its job list reads:
Both the
upload-pages-artifactstep and thedeployjob were gated ongithub.event_name == 'push' && github.ref == 'refs/heads/main'. Aworkflow_dispatchtherefore builds the docs and discards them.This matters beyond the one dispatch:
docs.ymlalso haspaths:filterson push, so a commit to
mainthat touches nothing underdocs/,mkdocs.yml,packages/**/src/**orexamples/**will not deploy either.Between the two, there was no way to bring the site up on demand at all.
The condition now leads with the ref, so a dispatch from a feature branch
cannot publish itself over the released documentation:
After merge, dispatch
docs.ymlonmainonce to bring the site up.🤖 Generated with Claude Code
https://claude.ai/code/session_01TcdE6eeSDBh8xrgKCoGrkw