You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR addresses #42 by cleaning up the vignette image paths.
My proposed structure is:
A figures/ directory under the vignettes/ directory.
Each vignette/article that uses figures has a subdirectory under figures/ with a name matching the name of the article (i.e. for an article titled my_article.Rmd, any images should be stored in the figures/my_article directory.
I cleaned up the 3 existing articles which use images to follow the above structure, and verified that the articles still build correctly locally (if someone could verify independently that would be great!)
@Andrew0Hill when you say build correctly locally do you mean something different than knitting the rmd file? Or you talking about packagedown? I've never used package down is this what I would do?
I checked this out I was able to see that all the images and the vignettes were built correctly. I think I have some things to learn about build_site() as I had to run that command a number of times and then manually install a number of packages I didn't have when it would fail to run. I got it to woke in the end though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #42 by cleaning up the vignette image paths.
My proposed structure is:
figures/directory under thevignettes/directory.figures/with a name matching the name of the article (i.e. for an article titledmy_article.Rmd, any images should be stored in thefigures/my_articledirectory.I cleaned up the 3 existing articles which use images to follow the above structure, and verified that the articles still build correctly locally (if someone could verify independently that would be great!)