Local Account: Hide delete & view logs, allow local account renaming,… - #341
Closed
parvathyabnair wants to merge 2 commits into
Closed
parvathyabnair wants to merge 2 commits into
parvathyabnair wants to merge 2 commits into
Conversation
… and fix input method commit
Contributor
Author
suraj-yadav0
requested changes
Sep 10, 2026
suraj-yadav0
left a comment
Collaborator
There was a problem hiding this comment.
Hi @parvathyabnair , I was thinking as of Now , We keep it simple and just hide the swipe actions for the Local
Account in Settings_Accounts.qml (set both leadingActions and trailingActions to null when model.id
=== 0). This fixes the exact confusion in issue #339 with just a few lines of code.
On Later stages we can introduce the Local Account rename Feature with Settings for Local Account as an Enhancement.
So revert the other changes and we are good to go. What do you think ?
Contributor
Author
|
Closing this PR, since another PR has been created with the requested changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description
Under Settings > Connected Accounts, the Local Account previously displayed non-functional swipe action options for Edit, Delete, and View Logs (with enabled: false), which caused confusion and made the UI appear unresponsive.
Type
Changes
1.Hides Delete and View Logs for Local Account: Sets trailingActions to null specifically for the Local Account (model.id === 0), completely removing the non-functional swipe-right actions while keeping them available for remote accounts.
2.Enables Local Account Editing:
Enables the swipe-left Edit action and allows direct row tapping on the Local Account item in Settings_Accounts.qml.
Opens Account_Page.qml in local mode: hides Server Connection, Credentials, and Sync Preferences sections, allowing the user to edit only the Local Account name.
Handles saving the custom name with non-empty validation and duplicate name checks via a new updateAccountName() helper in accounts.js.
3.Resolves Virtual Keyboard Pre-Edit Issue:
Calls Qt.inputMethod.commit() and transfers focus on Save to ensure single-word inputs from on-screen keyboards are committed from the pre-edit composition buffer before validation.
Sets inputMethodHints: Qt.ImhNoPredictiveText on input fields to prevent unconfirmed word buffering.
4.Maintains UI and Daemon Consistency:
Updates getAccountsList() and getAccountName() to preserve custom Local Account names instead of forcing hardcoded "Local".
Updates MenuPage.qml and AppDrawer.qml to display the renamed Local Account name in sidebar and drawer navigation.
Adds guards in daemon.py to ensure the background sync daemon never attempts to sync the local account even when renamed.
Adds website/ to .gitignore to prevent documentation build artifacts and node_modules from being committed.
Testing
clickable build && clickable review)clickable install)Screenshots (if UI change)
Checklist
mainorrelease\x.x.xbranchRelated Issues
Closes #
Additional Notes
#339