Skip to content

Fix temporary chat selector#315

Merged
CJackHwang merged 13 commits intoCJackHwang:mainfrom
catsimple:fix_temporary_chat_selector
Apr 16, 2026
Merged

Fix temporary chat selector#315
CJackHwang merged 13 commits intoCJackHwang:mainfrom
catsimple:fix_temporary_chat_selector

Conversation

@catsimple
Copy link
Copy Markdown
Contributor

16:51:40.859 WRN SYS 13shv1v [UI] Error in temporary chat mode: Locator.wait_for: Timeout 10000ms exceeded.
Call log:
- waiting for locator("button[aria-label=\"Temporary chat toggle\"]") to be visible
image

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@catsimple catsimple marked this pull request as draft April 14, 2026 17:35
@catsimple catsimple marked this pull request as ready for review April 14, 2026 17:50
@catsimple catsimple marked this pull request as draft April 14, 2026 18:04
Refactor enable_temporary_chat_mode to improve button visibility handling and streamline the process of enabling temporary chat mode.
@catsimple
Copy link
Copy Markdown
Contributor Author

google在灰度这个temporary chat按钮,放到折叠菜单里了,改了查找按钮逻辑mock过不去,看看是不是要改ci还是啥

@CJackHwang CJackHwang marked this pull request as ready for review April 16, 2026 13:33
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f6ba4c1b5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread browser_utils/initialization/core.py Outdated
Comment on lines +674 to +675
if await menu_trigger.get_attribute("aria-expanded") == "true":
logger.debug("[UI] Closing menu to restore UI state")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Guard menu state lookup before reading aria-expanded

enable_temporary_chat_mode unconditionally calls menu_trigger.get_attribute("aria-expanded") even when the View more actions button is not present in that UI variant. In Playwright, querying a missing locator can time out/throw, so this turns a best-effort helper into an exception path during startup or model-switch recovery (the catch block repeats the same call, which can re-raise). This should check that the menu trigger exists/is visible (or wrap the lookup) before reading attributes.

Useful? React with 👍 / 👎.

@CJackHwang
Copy link
Copy Markdown
Owner

这个项目年久失修了 我也很久没有调试和系统性重构 如果你修复后的这个问题能正常使用的话跟我说一声 我直接合并了

@catsimple
Copy link
Copy Markdown
Contributor Author

@CJackHwang 可以正常使用

@CJackHwang CJackHwang merged commit f5dcf82 into CJackHwang:main Apr 16, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants