Conversation
kkosang
approved these changes
Apr 26, 2025
Collaborator
kkosang
left a comment
kkosang
left a comment
There was a problem hiding this comment.
굿 좋습니다 몇가지 코멘트 남겨놨으니 확인 부탁드려요~
| ); | ||
| } | ||
|
|
||
| Widget _buildHeaderText() { |
Collaborator
There was a problem hiding this comment.
해당 파일명은 viewmodel인데, 안에는 Notifier로 쓰고 있네요 !
이 부분 통일 하는게 좋을 것 같아요
~notifier와 viewmodel 중 어떤 네이밍을 선호하시나요
Collaborator
Author
There was a problem hiding this comment.
아 그렇네요!! 뷰모델로 변경하겠습니다!!
| class ProfileIntroduceNotifier extends StateNotifier<ProfileIntroduceState> { | ||
| ProfileIntroduceNotifier() : super(ProfileIntroduceState()); | ||
|
|
||
| void updateIntroduction(String introduction) { |
Collaborator
There was a problem hiding this comment.
state를 갱신하는 로직이 조금 어색하게 느껴져요
isValid로 갱신하려는거면 아래와 같은 방법으로 검증하고 값을 넘겨주는게 어떤가요
final isValid = introduction.isNotEmpty && introduction.length <= 15;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
close #35
📝작업 내용
한 줄 자기소개 화면 구현
스크린샷 or 작업영상
Screen_recording_20250426_014814.webm
💬리뷰 요구사항
다음 계획
승인 대기중