Merged
Conversation
- email 정보 받도록 dto 수정, 로그인 이탈 시 분기처리
kkosang
added
feat
FLU0RITE
approved these changes
May 8, 2025
Comment on lines
+57
to
+69
| <activity android:name="com.aboutyou.dart_packages.sign_in_with_apple.CallbackActivity" | ||
| android:exported="true"> | ||
| <intent-filter> | ||
| <action android:name="android.intent.action.VIEW"/> | ||
| <category android:name="android.intent.category.DEFAULT"/> | ||
| <category android:name="android.intent.category.BROWSABLE"/> | ||
| <data | ||
| android:scheme="https" | ||
| android:host="chartreuse-gratis-lungfish.glitch.me" | ||
| android:pathPrefix="/callbacks/sign_in_with_apple"/> | ||
| </intent-filter> | ||
| </activity> | ||
|
|
Collaborator
There was a problem hiding this comment.
이게 꼭 필요한지는 잘 모르겠어요
처음에 없을 때도 잘 됬었거든요.. 일단 추가해 놓는 것은 좋은 것 같아요!
Collaborator
Author
There was a problem hiding this comment.
추후 리펙토링 단계에서 같이 알아보시죵~
FLU0RITE
reviewed
May 8, 2025
Comment on lines
+15
to
+31
|
|
||
| dio.interceptors.add(InterceptorsWrapper( | ||
| onRequest: (options, handler) async { | ||
| final token = await LoginLocalDataSource.loadToken(); | ||
|
|
||
| if (token != null && token.isNotEmpty) { | ||
| options.headers['Authorization'] = 'Bearer $token'; | ||
| } | ||
|
|
||
| return handler.next(options); | ||
| }, | ||
| onError: (e, handler) { | ||
| return handler.next(e); | ||
| }, | ||
| )); | ||
|
|
||
| return dio; |
Collaborator
Author
|
아 그리고 회원가입 API 호출 시, 받은 반환값으로 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
close #50
📝작업 내용
-> 이메일 추가되었습니다.
-> 회원가입 상태에 따른 분기 추가, 현재 소셜로그인, 전화번호 인증까지는 연결되어 있고 그 이후로 api 작업 완료되면 연결해야 할 것 같아요
스크린샷 or 작업영상
💬리뷰 요구사항
프로필 생성 네트워크 연결되면, 상태 저장하는 로직도 같이 추가되어야합니돠