feat: qa사항 반영 - #78
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
QA 피드백을 반영해 관리자 주문 카드, 프로필 이미지 미리보기, 일반·스페셜 룰렛 UI와 리소스를 수정했습니다.
FileReader기반 data URL에서 Blob URL 방식으로 변경했습니다.Confidence Score: 5/5
병합을 막는 오류는 확인되지 않았으며, Blob URL 정리 누락은 비차단 메모리 관리 문제입니다.
프로필 이미지를 새로 선택할 때는 이전 Blob URL을 해제하지만 기본 이미지 전환이나 unmount 시에는 해제하지 않아 브라우저 세션 동안 메모리가 누적될 수 있습니다. 기존 네 개의 리뷰 스레드는 모두 설명 없이 수동으로 해결 처리되었으므로 현재 평가를 낮추지 않았습니다.
Files Needing Attention: app/profile-image/_components/ProfileImageSelection.tsx
Important Files Changed
Reviews (4): Last reviewed commit: "feat: 이미지 로직 수정" | Re-trigger Greptile