-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/admin #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix/admin #105
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getActiveNotices의 매핑을/notices/active→/v1/notices/active로 바꾸면서 이전 경로에 대한 alias 가 전혀 없습니다. 클래스 레벨이@RequestMapping("/api")이므로 실제 경로는/api/notices/active→/api/v1/notices/active로 바뀌는데, 이 PR 은 gateway 설정(application.yml,application-aws.yml)의Pathpredicate 에/api/v1/notices/**를 추가만 하고 기존/api/notices/**는 그대로 남겨뒀습니다. 즉 gateway 는 여전히 구 경로 요청을 user-service 로 넘기지만, user-service 에는 더 이상 이를 처리하는 핸들러가 없어 이미 배포된 클라이언트(앱/웹)가 이 배포 직후 404 를 받게 됩니다.이 저장소는 서비스 경계를 넘는 변경의 하위 호환성을 특히 신경 쓰는데(CLAUDE.md 참고), 이번 건은 gateway ↔ user-service 배포 순서와 무관하게 클라이언트 배포 시점이 어긋나면 곧바로 깨지는 케이스입니다. 전환 기간 동안은 두 경로를 함께 열어두고, 클라이언트 전환이 끝난 뒤 구 경로와 gateway 의
/api/notices/**predicate 를 함께 제거하는 순서를 권장합니다.해당 코드:
Comatching5_BE/user-service/src/main/java/com/comatching/user/infra/controller/AdminNoticeController.java
Lines 72 to 76 in c3a9318