Board "fully" functioning

.github/workflows/docs.yml

@@ -1,69 +1,68 @@
-# Copyright (c) 2024, Nordic Semiconductor ASA
-# SPDX-License-Identifier: Apache-2.0
-
-name: Documentation
+name: Build and deploy documentation
 
 on:
-  pull_request:
   push:
-    branches:
-      - main
+    branches: [main]
+  pull_request:
+  workflow_dispatch:
 
 permissions:
   contents: read
 
+concurrency:
+  group: pages
+  cancel-in-progress: true
+
 jobs:
   build:
-    name: Build
-    runs-on: ubuntu-22.04
-    strategy:
-      matrix:
-        doxygen-version: [1.9.6, 1.14.0]
+    name: Build documentation
+    runs-on: ubuntu-latest
     steps:
       - name: Checkout
         uses: actions/checkout@v6
         with:
           persist-credentials: false
 
-      - name: Install dependencies
-        run: |
-          DOXYGEN_VERSION="${{ matrix.doxygen-version }}"
-          wget --no-verbose "https://github.com/doxygen/doxygen/releases/download/Release_${DOXYGEN_VERSION//./_}/doxygen-${DOXYGEN_VERSION}.linux.bin.tar.gz"
-          tar xf doxygen-${DOXYGEN_VERSION}.linux.bin.tar.gz
-          echo "${PWD}/doxygen-${DOXYGEN_VERSION}/bin" >> $GITHUB_PATH
-          pip install -r doc/requirements.txt
+      - name: Set up Python
+        uses: actions/setup-python@v6
+        with:
+          python-version: "3.12"
+          cache: pip
+          cache-dependency-path: doc/requirements.txt
 
-      - name: Build
+      - name: Install system dependencies
         run: |
-          cd doc
-          doxygen
+          sudo apt-get update
+          sudo apt-get install --no-install-recommends --yes doxygen
 
-          SPHINXOPTS="-W" make html
+      - name: Install Python dependencies
+        run: |
+          python -m pip install --upgrade pip
+          python -m pip install -r doc/requirements.txt
 
-          mkdir deploy
-          mv _build_doxygen/html deploy/doxygen
-          mv _build_sphinx/html/* deploy
+      - name: Build Sphinx HTML
+        run: python -m sphinx -b html doc doc/_build_sphinx/html
 
-      - name: Setup pages
-        if: github.event_name != 'pull_request' && matrix.doxygen-version == '1.14.0'
+      - name: Configure GitHub Pages
+        if: github.event_name != 'pull_request'
         uses: actions/configure-pages@v5
 
-      - name: Upload pages artifact
-        if: github.event_name != 'pull_request' && matrix.doxygen-version == '1.14.0'
-        uses: actions/upload-pages-artifact@v4
+      - name: Upload Pages artifact
+        if: github.event_name != 'pull_request'
+        uses: actions/upload-pages-artifact@v5
         with:
-          path: doc/deploy
+          path: doc/_build_sphinx/html
 
-      - name: Upload artifacts
+      - name: Upload PR documentation artifact
         if: github.event_name == 'pull_request'
         uses: actions/upload-artifact@v4
         with:
-          name: docs-doxygen-${{ matrix.doxygen-version }}
-          path: doc/deploy
+          name: documentation-html
+          path: doc/_build_sphinx/html
 
   deploy:
-    name: Deploy
-    runs-on: ubuntu-22.04
+    name: Deploy documentation
+    runs-on: ubuntu-latest
     needs: build
     if: github.event_name != 'pull_request'
     permissions:

.gitignore

@@ -15,3 +15,4 @@ __pycache__/
 # docs
 /doc/_build*
 /app/build/
+/doc/_doxygen/

README.md

@@ -55,8 +55,8 @@ Default command responses use:
 cmd/hsfib-tib/resp/<key>
 ```
 
-MQTT 5 `response_topic` and `correlation_data` are honored when they fit the
-fixed command buffers.
+MQTT 5 `response_topic` is honored when it fits the fixed topic buffer.
+`correlation_data` is echoed when it is 16 bytes or less.
 
 Serial commands share the same normalized command path. A bare serial key is a
 GET; a key with payload is a SET. See:
@@ -68,16 +68,18 @@ GET; a key with payload is a SET. See:
 ## Runtime Shape
 
 - `main.c`: boot order, watchdog feed, network/MQTT loop, outbound publish.
-- `command.c`: MQTT/serial ingress, serial guard, dispatch, response queues.
+- `command.c`: app command queues, serial guard policy, command table, and
+  command handlers, using `lib/coo_commons/command_dispatch.c` for reusable
+  MQTT/serial request and response mechanics.
 - `devices.c`: board strap detection and board-profile setup.
 - `mems_switching.c`: MEMS switch state, routes, and toggler work.
 - `attenuator.c`: DAC-backed logical attenuator control and calibration.
 - `maiman.c` and `lasers.c`: Maiman Modbus and laser-bank helpers.
 - `photodiode.c`: ADS1115 sampling, dark calibration, noise, telemetry.
 - `tempsense.c`: DS18B20 ambient temperature cache.
 - `sntp_sync.c`: SNTP sync and time status.
-- `app_settings.c`: Zephyr settings-backed app state.
-- `app_warning.c`: best-effort warning publication.
+- `app_settings.c`: app-owned runtime settings and direct Zephyr NVS persistence.
+- `app_identity.c`: selected board-profile MQTT device ID.
 
 Architecture pages live in `doc/architecture.md`, `doc/threads.md`, and `doc/queues_and_work.md`.
 

agents.md

@@ -105,6 +105,11 @@ Build discipline:
     - newly introduced non-blocking warnings,
     - tests or static checks run.
 
+Workspace metadata discipline:
+
+- Do not edit files under `.idea/`. Those files are developer IDE state, not
+  firmware source or documentation.
+
 ---
 
 ## 4. Coding Style and Architecture
@@ -406,4 +411,4 @@ Before finalizing, self-review:
 - Did this add blocking behavior to a timing-sensitive path?
 - Did this preserve best-effort warnings and telemetry?
 - Did this require a west build?
-- Were build steps sequential?
+- Were build steps sequential?

app/CMakeLists.txt

@@ -18,30 +18,26 @@ project(app LANGUAGES C)
 
 target_sources(app PRIVATE
         src/main.c
-        src/app_scheduled_actions.c
+        src/app_identity.c
         src/app_settings.c
-        src/app_warning.c
         src/attenuator.c
+        src/attenuator_calibration.c
+        src/attenuator_command.c
         src/command.c
         src/devices.c
+        src/housekeeping.c
+        src/laser_command.c
         src/lasers.c
+        src/laserbank_tempcontrol.c
         src/maiman.c
+        src/mems_command.c
         src/photodiode.c
-        src/tempsense.c
-        src/tempsense.h
+        src/photodiode_command.c
+        src/throughput_command.c
+        src/throughput_monitor.c
         src/mems_switching.c
+)
+
+target_sources_ifdef(CONFIG_SNTP app PRIVATE
         src/sntp_sync.c
-        src/attenuator.h
-        src/app_scheduled_actions.h
-        src/app_settings.h
-        src/app_warning.h
-        src/app_identity.h
-        src/command.h
-        src/devices.h
-        src/lasers.h
-        src/maiman.h
-        src/laser_properties.h
-        src/photodiode.h
-        src/mems_switching.h
-        src/sntp_sync.h
 )

app/Kconfig

@@ -10,6 +10,28 @@ menu "Zephyr"
 source "Kconfig.zephyr"
 endmenu
 
+config NET_DHCPV4_OPTION_NTP_SERVER
+	default y if SNTP && NET_DHCPV4
+
+config APP_DEFAULT_DNS_SERVER
+	string "Default manual DNS server IPv4 address"
+	default "0.0.0.0"
+	help
+	  Default app-owned manual DNS server stored in the initial settings
+	  snapshot. Use 0.0.0.0 to leave manual DNS disabled.
+
+config APP_DEFAULT_NTP_SERVER
+	string "Default manual NTP server IPv4 address"
+	default "0.0.0.0"
+	help
+	  Default app-owned manual NTP server stored in the initial settings
+	  snapshot. The current settings schema stores IPv4 strings, not
+	  hostnames. Use 0.0.0.0 to prefer DHCP-provided NTP.
+
+choice SNTP_LOG_LEVEL_CHOICE
+	default SNTP_LOG_LEVEL_DBG if SNTP
+endchoice
+
 module = APP
 module-str = APP
 source "subsys/logging/Kconfig.template.log_config"